Re: memtest updates

[Alexander Aring <alex.aring@gmail.com>]

On Tue, Oct 27, 2015 at 09:29:53AM +0100, Sascha Hauer wrote:
> This series has some updates for the memory test. The output and the
> code are made more compact and some additional options are added. Also
> the remap_range function is reworked.
> 

I currently try to build next with memtest, I got the following issue:

commands/memtest.c: In function 'do_test_one_area':
commands/memtest.c:50:2: error: implicit declaration of function 'mem_test_moving_inversions_pattern' [-Werror=implicit-function-declaration]
  ret = mem_test_moving_inversions_pattern(r->r->start, r->r->end, 0xdeadbeef);

after running grep I realized and there is no
"mem_test_moving_inversions_pattern" function. :-(

Then:

after cutting some words from this function and running grep again, then
I found a "mem_test_moving_inversions" function. :-)

It seems it's a different function and you passed a "0xdeadbeef" there,
otherwise the function fits.

What means 0xdeadbeef here?

Anyway I applied:

diff --git a/commands/memtest.c b/commands/memtest.c
index 88656df..d784a5c 100644
--- a/commands/memtest.c
+++ b/commands/memtest.c
@@ -47,7 +47,7 @@ static int do_test_one_area(struct mem_test_resource *r, int bus_only,
        if (bus_only)
                return 0;
 
-       ret = mem_test_moving_inversions_pattern(r->r->start, r->r->end, 0xdeadbeef);
+       ret = mem_test_moving_inversions(r->r->start, r->r->end);
        if (ret < 0)
                return ret;
        printf("done.\n\n");


and it seems to solve this compiling issue.

- Alex

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox