From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr7jI-0001JN-5u for qemu-devel@nongnu.org; Tue, 27 Oct 2015 13:08:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zr7jC-0002B6-5L for qemu-devel@nongnu.org; Tue, 27 Oct 2015 13:08:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59399) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr7jC-0002B2-0b for qemu-devel@nongnu.org; Tue, 27 Oct 2015 13:08:06 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 55BA28F293 for ; Tue, 27 Oct 2015 17:08:05 +0000 (UTC) Date: Tue, 27 Oct 2015 15:08:02 -0200 From: Eduardo Habkost Message-ID: <20151027170802.GI4180@thinpad.lan.raisama.net> References: <1445879623-8403-1-git-send-email-ehabkost@redhat.com> <562E7AA7.3080300@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <562E7AA7.3080300@redhat.com> Subject: Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Paolo Bonzini , Andrew Jones , qemu-devel@nongnu.org, Markus Armbruster On Mon, Oct 26, 2015 at 01:10:31PM -0600, Eric Blake wrote: > On 10/26/2015 11:13 AM, Eduardo Habkost wrote: > > This replaces most fprintf(stderr) calls on vl.c with error_report(). > > > > The trailing newlines, "qemu:" and "error:" message prefixes were > > removed. > > > > The only remaining fprintf(stderr) calls are the ones at > > qemu_kill_report(), because the error mesage is split in multiple > > fprintf() calls. > > > > Signed-off-by: Eduardo Habkost > > --- > > Not sure if this is appropriate post soft-freeze, but if we are going to apply > > the max-cpus patch from Drew before 2.5.0, we could simply change all the > > fprintf() calls in a single step. > > Soft freeze means no new features that didn't already have a patch > review started - but this is a cleanup, not a new feature. I think it > qualifies for 2.5 inclusion just fine. Makes sense. Thanks for the input! > > > --- > > vl.c | 228 +++++++++++++++++++++++++++++++++---------------------------------- > > 1 file changed, 112 insertions(+), 116 deletions(-) > > In addition to the things Markus pointed out, > [many suggestions] > > Whether you squash in those fixes, roll a v2, or send a followup, feel > free to add: > > Reviewed-by: Eric Blake Except for the indentation fix (which I already fixed in my git tree), I will send them as a follow-up. Thanks! -- Eduardo