All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Duyck <aduyck@mirantis.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH 0/5] Misc Intel driver cleanups
Date: Tue, 27 Oct 2015 16:59:05 -0700	[thread overview]
Message-ID: <20151027235341.30048.46286.stgit@localhost.localdomain> (raw)

These are some assorted cleanups that occurred to me over the last several
days.  They are compile tested only.

The first three are based on review of some patches I saw recently accepted
into fm10k.  We weren't doing consistent exception handling when we
probably should have been.  Also it looks like there are some exception
paths what would have likely resulted in a kernel panic so I decided to try
and address those.

The fourth is based on a suggestion I had given to Nick but he ignored.
Basically e1000e_up is always returning 0, there was code that was checking
for it returning non-zero so I make e1000e_up void and dropped all code
that was checking it for a non-zero return value.

The last patch is a minor tweak to an existing patch in the dev-queue.
Feel free to just fold it into the patch it fixes and add my signed-off-by
or carry it separately.  I am good either way.

---

Alexander Duyck (5):
      fm10k: Cleanup MSI-X interrupts in case of failure
      fm10k: Cleanup exception handling for mailbox interrupt
      fm10k: Cleanup exception handling for changing queues
      e1000e: Switch e1000e_up to void, drop code checking for error result
      igb: Fix unused variable warning


 drivers/net/ethernet/intel/e1000e/e1000.h       |    2 -
 drivers/net/ethernet/intel/e1000e/netdev.c      |   15 +----
 drivers/net/ethernet/intel/fm10k/fm10k_main.c   |    4 +
 drivers/net/ethernet/intel/fm10k/fm10k_netdev.c |   17 ++++--
 drivers/net/ethernet/intel/fm10k/fm10k_pci.c    |   68 ++++++++++++++++++-----
 drivers/net/ethernet/intel/igb/igb_main.c       |    1 
 6 files changed, 74 insertions(+), 33 deletions(-)

--

             reply	other threads:[~2015-10-27 23:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 23:59 Alexander Duyck [this message]
2015-10-27 23:59 ` [Intel-wired-lan] [next PATCH 1/5] fm10k: Cleanup MSI-X interrupts in case of failure Alexander Duyck
2015-10-28 16:11   ` Allan, Bruce W
2015-11-03 20:45     ` Singh, Krishneil K
2015-10-27 23:59 ` [Intel-wired-lan] [next PATCH 2/5] fm10k: Cleanup exception handling for mailbox interrupt Alexander Duyck
2015-10-28 16:11   ` Allan, Bruce W
2015-11-03 20:47   ` Singh, Krishneil K
2015-10-27 23:59 ` [Intel-wired-lan] [next PATCH 3/5] fm10k: Cleanup exception handling for changing queues Alexander Duyck
2015-10-28 16:11   ` Allan, Bruce W
2015-10-29 19:12   ` Allan, Bruce W
2015-10-29 19:39     ` Alexander Duyck
2015-11-03 23:20       ` Allan, Bruce W
2015-11-10 16:46         ` Allan, Bruce W
2015-11-10 17:30       ` Jeff Kirsher
2015-11-03 20:48   ` Singh, Krishneil K
2015-10-27 23:59 ` [Intel-wired-lan] [next PATCH 4/5] e1000e: Switch e1000e_up to void, drop code checking for error result Alexander Duyck
2015-11-20  4:48   ` Brown, Aaron F
2015-10-27 23:59 ` [Intel-wired-lan] [next PATCH 5/5] igb: Fix unused variable warning Alexander Duyck
2015-11-20  4:50   ` Brown, Aaron F

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151027235341.30048.46286.stgit@localhost.localdomain \
    --to=aduyck@mirantis.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.