From: Joerg Roedel <jroedel@suse.de>
To: Andy Lutomirski <luto@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Sebastian Ott <sebott@linux.vnet.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Christoph Hellwig <hch@lst.de>,
benh@kernel.crashing.org, KVM <kvm@vger.kernel.org>,
dwmw2@infradead.org, Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-s390 <linux-s390@vger.kernel.org>,
Andy Lutomirski <luto@amacapital.net>
Subject: Re: [PATCH 1/3] virtio_net: Stop doing DMA from the stack
Date: Wed, 28 Oct 2015 11:07:50 +0900 [thread overview]
Message-ID: <20151028020750.GB18467@suse.de> (raw)
In-Reply-To: <b049d57c66d2fa62e0bafa9cf982de62310f4423.1445994839.git.luto@kernel.org>
On Tue, Oct 27, 2015 at 06:17:08PM -0700, Andy Lutomirski wrote:
> From: Andy Lutomirski <luto@amacapital.net>
>
> Once virtio starts using the DMA API, we won't be able to safely DMA
> from the stack. virtio-net does a couple of config DMA requests
> from small stack buffers -- switch to using dynamically-allocated
> memory.
>
> This should have no effect on any performance-critical code paths.
>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
> drivers/net/virtio_net.c | 53 ++++++++++++++++++++++++++++++++----------------
> 1 file changed, 36 insertions(+), 17 deletions(-)
Reviewed-by: Joerg Roedel <jroedel@suse.de>
next prev parent reply other threads:[~2015-10-28 2:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 1:17 [PATCH 0/3] virtio DMA API core stuff Andy Lutomirski
2015-10-28 1:17 ` [PATCH 1/3] virtio_net: Stop doing DMA from the stack Andy Lutomirski
2015-10-28 2:07 ` Joerg Roedel [this message]
2015-10-28 2:14 ` Andy Lutomirski
2015-10-28 1:17 ` [PATCH 2/3] virtio_ring: Support DMA APIs Andy Lutomirski
2015-10-28 2:06 ` Joerg Roedel
2015-10-28 2:13 ` Andy Lutomirski
2015-10-28 2:21 ` Joerg Roedel
2015-10-28 5:12 ` Andy Lutomirski
2015-10-28 2:27 ` Christian Borntraeger
2015-10-28 5:09 ` Andy Lutomirski
2015-10-28 1:17 ` [PATCH 3/3] virtio_pci: Use the DMA API Andy Lutomirski
2015-10-28 2:15 ` Joerg Roedel
2015-10-28 2:22 ` David Woodhouse
2015-10-28 2:50 ` Joerg Roedel
2015-10-28 2:25 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151028020750.GB18467@suse.de \
--to=jroedel@suse.de \
--cc=benh@kernel.crashing.org \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=dwmw2@infradead.org \
--cc=hch@lst.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=pbonzini@redhat.com \
--cc=schwidefsky@de.ibm.com \
--cc=sebott@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.