All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Cc: outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] [PATCH] Staging: comedi: Use rwsemaphore
Date: Wed, 28 Oct 2015 13:46:25 +0900	[thread overview]
Message-ID: <20151028044625.GA6015@kroah.com> (raw)
In-Reply-To: <1446006196-6294-1-git-send-email-ksenija.stanojevic@gmail.com>

On Tue, Oct 27, 2015 at 09:23:16PM -0700, Ksenija Stanojevic wrote:
> Functions that use semaphore for locking are divided into read/write
> functions, so use locking mechanism that provides similar semantics.
> 
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>

Unless you can measure the speed differences by switching to such a
lock, never switch to such a lock as they are much more complex and can
actually cause things to go _slower_.

So I can't take this patch unless you have measureable benchmark
numbers.

thanks,

greg k-h


  reply	other threads:[~2015-10-28  4:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28  4:23 [PATCH] Staging: comedi: Use rwsemaphore Ksenija Stanojevic
2015-10-28  4:46 ` Greg KH [this message]
2015-10-29 22:20   ` [Outreachy kernel] " Arnd Bergmann
2015-10-29 22:33     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151028044625.GA6015@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ksenija.stanojevic@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.