From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755672AbbJ1JyQ (ORCPT ); Wed, 28 Oct 2015 05:54:16 -0400 Received: from mail-lf0-f42.google.com ([209.85.215.42]:34745 "EHLO mail-lf0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755608AbbJ1JyP (ORCPT ); Wed, 28 Oct 2015 05:54:15 -0400 Date: Wed, 28 Oct 2015 10:54:14 +0100 From: Johan Hovold To: Julia Lawall Cc: Johan Hovold , Michal Marek , Gilles Muller , Nicolas Palix , linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr Subject: Re: [PATCH] coccinelle: misc: remove "complex return code" warnings Message-ID: <20151028095414.GD28572@localhost> References: <1443652647-23097-1-git-send-email-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 03, 2015 at 06:25:39PM +0200, Julia Lawall wrote: > Should have acked this message... > > Acked-by: Julia Lawall > > On Wed, 30 Sep 2015, Johan Hovold wrote: > > > This effectively reverts 932058a5d5f9 ("coccinelle: misc: semantic patch > > to delete overly complex return code processing"). > > > > There can be both symmetry and readability reasons for not wanting to do > > the final function call as part of the return statement and to maintain > > a clear separation of success and error paths. > > > > Since this is in no way mandated by the coding standard, let's just > > remove this semantic patch to avoid having "clean up" patches being > > posted over and over in response to these Coccinelle warnings. > > > > Signed-off-by: Johan Hovold Is anyone planning on picking this patch up? Thanks, Johan