Re: [Xenomai] [PATCH] scripts: use mktemp instead of relying on TMPDIR beeing in env

[Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>]

On Wed, Oct 28, 2015 at 09:33:13AM +0100, Henning Schild wrote:
> On Tue, 27 Oct 2015 13:35:40 +0100
> Henning Schild <henning.schild@siemens.com> wrote:
> 
> > On Tue, 27 Oct 2015 13:30:04 +0100
> > Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org> wrote:
> > 
> > > On Tue, Oct 27, 2015 at 01:21:16PM +0100, Henning Schild wrote:
> > > > The environment variable TMPDIR is optional and not always set. We
> > > > could test for it and fall back to /tmp/ or just use the tool
> > > > mktemp.
> > > 
> > > I am not sure mktemp is available everywhere. What about setting
> > > TMPDIR to /tmp if not set ?
> > 
> > From what i can tell mktemp is more widely available than TMPDIR. My
> > gentoo boxes do not have TMPDIR set and i have used a ubuntu system
> > where it was not set either. mktemp is part of coreutils and even
> > busybox has one.
> > I did not feel too good reimplementing whatever else mktemp does, why
> > reinvent the wheel?
> 
> Please let me know whether i was convincing and the current patch
> version will be merged.

The patch is ok for me minus the use of $() which is used nowhere
else in the script and not strictly necessary (no nesting needed).

-- 
					    Gilles.
https://click-hack.org