From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755918AbbJ1No1 (ORCPT ); Wed, 28 Oct 2015 09:44:27 -0400 Received: from mail.kernel.org ([198.145.29.136]:39109 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753221AbbJ1NoZ (ORCPT ); Wed, 28 Oct 2015 09:44:25 -0400 Date: Wed, 28 Oct 2015 10:44:20 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Wang Nan , ast@kernel.org, brendan.d.gregg@gmail.com, jolsa@kernel.org, lizefan@huawei.com, pi3orama@163.com, davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Alexei Starovoitov , Peter Zijlstra Subject: Re: [RFC PATCH net-next 1/4] perf tools: Enable pre-event inherit setting by config terms Message-ID: <20151028134420.GA17877@kernel.org> References: <1446029705-199659-1-git-send-email-wangnan0@huawei.com> <1446029705-199659-2-git-send-email-wangnan0@huawei.com> <20151028132126.GD5216@krava.brq.redhat.com> <20151028134213.GC18670@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151028134213.GC18670@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Oct 28, 2015 at 10:42:13AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Oct 28, 2015 at 02:21:26PM +0100, Jiri Olsa escreveu: > > On Wed, Oct 28, 2015 at 10:55:02AM +0000, Wang Nan wrote: > > > @@ -55,6 +56,7 @@ struct perf_evsel_config_term { > > > bool time; > > > char *callgraph; > > > u64 stack_user; > > > + u64 inherit; > > > > seems like bool would be enough > > Ok, will change this and move it to a more suitable place member > alignment wise. Nah, switched it to bool, but no need to move it around, that is an union... > Can I, with this change, slap an Acked-by: jirka? > > - Arnaldo