diff for duplicates of <20151028135149.GF4058@x1> diff --git a/a/1.txt b/N1/1.txt index c5393ce..8be82cb 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,15 +2,18 @@ On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: > W dniu 28.10.2015 o 17:46, Lee Jones pisze: > > On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: -> > +> >=20 > >> On 26.10.2015 23:34, Lee Jones wrote: > >>> On Mon, 26 Oct 2015, Alim Akhtar wrote: > >>> > >>>> From: Thomas Abraham <thomas.ab@samsung.com> > >>>> -> >>>> Add support for S2MPS15 PMIC which is similar to S2MPS11 PMIC. The S2MPS15 -> >>>> PMIC supports 27 LDO regulators, 10 buck regulators, RTC, three 32.768KHz -> >>>> clock outputs and battery charger. This patch adds initial support for +> >>>> Add support for S2MPS15 PMIC which is similar to S2MPS11 PMIC. The S= +2MPS15 +> >>>> PMIC supports 27 LDO regulators, 10 buck regulators, RTC, three 32.7= +68KHz +> >>>> clock outputs and battery charger. This patch adds initial support f= +or > >>>> LDO and buck regulators of S2MPS15 device. > >>>> > >>>> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com> @@ -21,7 +24,8 @@ On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: > >>>> drivers/mfd/sec-core.c | 31 +++++++ > >>>> drivers/mfd/sec-irq.c | 8 ++ > >>>> include/linux/mfd/samsung/core.h | 1 + -> >>>> include/linux/mfd/samsung/s2mps15.h | 158 +++++++++++++++++++++++++++++++++++ +> >>>> include/linux/mfd/samsung/s2mps15.h | 158 ++++++++++++++++++++++++= ++++++++++++ > >>>> 4 files changed, 198 insertions(+) > >>>> create mode 100644 include/linux/mfd/samsung/s2mps15.h > >>> @@ -36,25 +40,26 @@ On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: > >> - driver name: sec_pmic > >> > >> 2. Regulator driver: -> >> - no compatible (because it always searches for "regulators" subnode of +> >> - no compatible (because it always searches for "regulators" subnode = +of > >> its parent... that is the convention/legacy behaviour) > >> - driver name: s2mps1*-pmic > >> > >> I hope that explains your concerns. -> > +> >=20 > > It explains *why*, but doesn't ease my concerns in any way. -> > +> >=20 > > Unfortunately I've only just realised the disparity we have between > > MFD and the Regulator subsystem, which is annoying because it's now -> > almost impossible to rectify. -> > +> > almost impossible to rectify. =20 +> >=20 > > We should have taken one of two views. Either a) The MFD is the PMIC > > device which encompasses regulator control. In which case the MFD > > and it's corresponding compatible string would be named *-pmic and the > > regulator driver would be called *-regulator. Or b) The MFD could be > > considered a normal MFD and be named after the model number, then the > > regulator 'could' be named *-pmic. -> > +> >=20 > > However, with reference to b), how much other Power Management does > > the regulator driver do besides control regulators? I suspect not > > much. Therefore my preference would be for a). My second choice @@ -62,19 +67,19 @@ On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: > > last option on my list would be the current situation where we seem to > > be calling both the MFD (PMIC) itself and the Regulator driver > > *-pmic, which is not good. -> +>=20 > Starting from the description of device-family. This is called "Power > Management IC" but it is rather a "Power Deliver/Distribute IC". There > isn't any logic inside except enable/disable/configure/set low power > mode for regulators. -> +>=20 > However in the same time the IC comes (always) with: > - 32kHz clocks, > - RTC, > - backup battery charger (no driver for it), > - reset for SoC, > - shutdown on thermal alert (also no driver for this control). -> +>=20 > The solution a) seems fine to me. Make sense and it looks entirely > backward compatible - only driver names will be modified. @@ -82,8 +87,21 @@ Perfect solution from my PoV. Thanks Krzysztof. --- +--=20 Lee Jones Linaro STMicroelectronics Landing Team Lead -Linaro.org │ Open source software for ARM SoCs +Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog + +--=20 +--=20 +You received this message because you are subscribed to "rtc-linux". +Membership options at http://groups.google.com/group/rtc-linux . +Please read http://groups.google.com/group/rtc-linux/web/checklist +before submitting a driver. +---=20 +You received this message because you are subscribed to the Google Groups "= +rtc-linux" group. +To unsubscribe from this group and stop receiving emails from it, send an e= +mail to rtc-linux+unsubscribe@googlegroups.com. +For more options, visit https://groups.google.com/d/optout. diff --git a/a/content_digest b/N1/content_digest index 728ced9..36655da 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,7 +5,7 @@ "ref\020151028084609.GG5828@x1\0" "ref\05630D12C.2030008@samsung.com\0" "From\0Lee Jones <lee.jones@linaro.org>\0" - "Subject\0Re: [PATCH v3 2/5] mfd: sec: Add support for S2MPS15 PMIC\0" + "Subject\0[rtc-linux] Re: [PATCH v3 2/5] mfd: sec: Add support for S2MPS15 PMIC\0" "Date\0Wed, 28 Oct 2015 13:51:49 +0000\0" "To\0Krzysztof Kozlowski <k.kozlowski@samsung.com>\0" "Cc\0k.kozlowski.k@gmail.com" @@ -23,15 +23,18 @@ "\n" "> W dniu 28.10.2015 o 17:46, Lee Jones pisze:\n" "> > On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote:\n" - "> > \n" + "> >=20\n" "> >> On 26.10.2015 23:34, Lee Jones wrote:\n" "> >>> On Mon, 26 Oct 2015, Alim Akhtar wrote:\n" "> >>>\n" "> >>>> From: Thomas Abraham <thomas.ab@samsung.com>\n" "> >>>>\n" - "> >>>> Add support for S2MPS15 PMIC which is similar to S2MPS11 PMIC. The S2MPS15\n" - "> >>>> PMIC supports 27 LDO regulators, 10 buck regulators, RTC, three 32.768KHz\n" - "> >>>> clock outputs and battery charger. This patch adds initial support for\n" + "> >>>> Add support for S2MPS15 PMIC which is similar to S2MPS11 PMIC. The S=\n" + "2MPS15\n" + "> >>>> PMIC supports 27 LDO regulators, 10 buck regulators, RTC, three 32.7=\n" + "68KHz\n" + "> >>>> clock outputs and battery charger. This patch adds initial support f=\n" + "or\n" "> >>>> LDO and buck regulators of S2MPS15 device.\n" "> >>>>\n" "> >>>> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>\n" @@ -42,7 +45,8 @@ "> >>>> drivers/mfd/sec-core.c | 31 +++++++\n" "> >>>> drivers/mfd/sec-irq.c | 8 ++\n" "> >>>> include/linux/mfd/samsung/core.h | 1 +\n" - "> >>>> include/linux/mfd/samsung/s2mps15.h | 158 +++++++++++++++++++++++++++++++++++\n" + "> >>>> include/linux/mfd/samsung/s2mps15.h | 158 ++++++++++++++++++++++++=\n" + "+++++++++++\n" "> >>>> 4 files changed, 198 insertions(+)\n" "> >>>> create mode 100644 include/linux/mfd/samsung/s2mps15.h\n" "> >>>\n" @@ -57,25 +61,26 @@ "> >> - driver name: sec_pmic\n" "> >>\n" "> >> 2. Regulator driver:\n" - "> >> - no compatible (because it always searches for \"regulators\" subnode of\n" + "> >> - no compatible (because it always searches for \"regulators\" subnode =\n" + "of\n" "> >> its parent... that is the convention/legacy behaviour)\n" "> >> - driver name: s2mps1*-pmic\n" "> >>\n" "> >> I hope that explains your concerns.\n" - "> > \n" + "> >=20\n" "> > It explains *why*, but doesn't ease my concerns in any way.\n" - "> > \n" + "> >=20\n" "> > Unfortunately I've only just realised the disparity we have between\n" "> > MFD and the Regulator subsystem, which is annoying because it's now\n" - "> > almost impossible to rectify. \n" - "> > \n" + "> > almost impossible to rectify. =20\n" + "> >=20\n" "> > We should have taken one of two views. Either a) The MFD is the PMIC\n" "> > device which encompasses regulator control. In which case the MFD\n" "> > and it's corresponding compatible string would be named *-pmic and the\n" "> > regulator driver would be called *-regulator. Or b) The MFD could be\n" "> > considered a normal MFD and be named after the model number, then the\n" "> > regulator 'could' be named *-pmic.\n" - "> > \n" + "> >=20\n" "> > However, with reference to b), how much other Power Management does\n" "> > the regulator driver do besides control regulators? I suspect not\n" "> > much. Therefore my preference would be for a). My second choice\n" @@ -83,19 +88,19 @@ "> > last option on my list would be the current situation where we seem to\n" "> > be calling both the MFD (PMIC) itself and the Regulator driver\n" "> > *-pmic, which is not good.\n" - "> \n" + ">=20\n" "> Starting from the description of device-family. This is called \"Power\n" "> Management IC\" but it is rather a \"Power Deliver/Distribute IC\". There\n" "> isn't any logic inside except enable/disable/configure/set low power\n" "> mode for regulators.\n" - "> \n" + ">=20\n" "> However in the same time the IC comes (always) with:\n" "> - 32kHz clocks,\n" "> - RTC,\n" "> - backup battery charger (no driver for it),\n" "> - reset for SoC,\n" "> - shutdown on thermal alert (also no driver for this control).\n" - "> \n" + ">=20\n" "> The solution a) seems fine to me. Make sense and it looks entirely\n" "> backward compatible - only driver names will be modified.\n" "\n" @@ -103,10 +108,23 @@ "\n" "Thanks Krzysztof.\n" "\n" - "-- \n" + "--=20\n" "Lee Jones\n" "Linaro STMicroelectronics Landing Team Lead\n" - "Linaro.org \342\224\202 Open source software for ARM SoCs\n" - Follow Linaro: Facebook | Twitter | Blog + "Linaro.org =E2=94=82 Open source software for ARM SoCs\n" + "Follow Linaro: Facebook | Twitter | Blog\n" + "\n" + "--=20\n" + "--=20\n" + "You received this message because you are subscribed to \"rtc-linux\".\n" + "Membership options at http://groups.google.com/group/rtc-linux .\n" + "Please read http://groups.google.com/group/rtc-linux/web/checklist\n" + "before submitting a driver.\n" + "---=20\n" + "You received this message because you are subscribed to the Google Groups \"=\n" + "rtc-linux\" group.\n" + "To unsubscribe from this group and stop receiving emails from it, send an e=\n" + "mail to rtc-linux+unsubscribe@googlegroups.com.\n" + For more options, visit https://groups.google.com/d/optout. -6e374947d6767168ef6d8bc0396a922556f5dfdf86ad21f910f461bc88d1b145 +0a31dcf5f80739476259d96105578a979c66613967927dd6fd8c2382e25ff621
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.