From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756136AbbJ1Sxq (ORCPT ); Wed, 28 Oct 2015 14:53:46 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:30693 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755722AbbJ1Sxo (ORCPT ); Wed, 28 Oct 2015 14:53:44 -0400 Date: Wed, 28 Oct 2015 21:53:30 +0300 From: Dan Carpenter To: Bogicevic Sasa Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] drivers:staging:gdm724x Fix Alignment should match open parenthesis Message-ID: <20151028185330.GC18797@mwanda> References: <1446056004-6092-1-git-send-email-brutallesale@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446056004-6092-1-git-send-email-brutallesale@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 28, 2015 at 07:13:24PM +0100, Bogicevic Sasa wrote: > This fixes all Alignment should match open parenthesis > messages from checkpatch.pl > > Signed-off-by: Bogicevic Sasa > --- > drivers/staging/gdm724x/gdm_lte.c | 69 +++++++++++++++++++++++++-------------- > 1 file changed, 45 insertions(+), 24 deletions(-) > > diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c > index a8d2cff..a28e0d1 100644 > --- a/drivers/staging/gdm724x/gdm_lte.c > +++ b/drivers/staging/gdm724x/gdm_lte.c > @@ -161,12 +161,15 @@ static int gdm_lte_emulate_arp(struct sk_buff *skb_in, u32 nic_type) > return -ENOMEM; > skb_reserve(skb_out, NET_IP_ALIGN); > > - memcpy(skb_put(skb_out, mac_header_len), mac_header_data, > + memcpy( > + skb_put(skb_out, mac_header_len), mac_header_data, > mac_header_len); No. This isn't the right way. Look at other code to see how it's done. regards, dan carpenter