All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Cc: dm-devel@redhat.com, mpatocka@redhat.com
Subject: Re: [PATCH 6/6] dm-stripe: Fix error message
Date: Wed, 28 Oct 2015 15:51:28 -0400	[thread overview]
Message-ID: <20151028195128.GA22241@redhat.com> (raw)
In-Reply-To: <1445974740-8362-6-git-send-email-kusumi.tomohiro@gmail.com>

On Tue, Oct 27 2015 at  3:39pm -0400,
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> wrote:

> The meaning of "not divisible by chunk size" has changed after
> d793e684, so the error message here should probably be using
> "Stripe length" since tmp_len is result of width/stripes, but
> not the whole target device size.
> 
> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
> ---
>  drivers/md/dm-stripe.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/md/dm-stripe.c b/drivers/md/dm-stripe.c
> index 797ddb9..85cb09f 100644
> --- a/drivers/md/dm-stripe.c
> +++ b/drivers/md/dm-stripe.c
> @@ -127,7 +127,7 @@ static int stripe_ctr(struct dm_target *ti, unsigned int argc, char **argv)
>  
>  	tmp_len = width;
>  	if (sector_div(tmp_len, chunk_size)) {
> -		ti->error = "Target length not divisible by "
> +		ti->error = "Stripe length not divisible by "
>  		    "chunk size";
>  		return -EINVAL;
>  	}

There is no need for this change.  The user-facing error is more
meaningful.  The only input that is being checked here is the specified
target length.

Dropping this patch.

  reply	other threads:[~2015-10-28 19:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 19:38 [PATCH 1/6] dm-delay: Use DM_MAPIO_XXX macros instead of 0/1 (resend) Tomohiro Kusumi
2015-10-27 19:38 ` [PATCH 2/6] dm-delay: Update documentation for offsets (resend) Tomohiro Kusumi
2015-10-27 19:38 ` [PATCH 3/6] dm-delay: Capitalize error message consistently Tomohiro Kusumi
2015-10-27 19:38 ` [PATCH 4/6] dm-linear: Improve error message consistency Tomohiro Kusumi
2015-10-27 19:38 ` [PATCH 5/6] dm-switch: Remove unnecessary condition in conditional Tomohiro Kusumi
2015-10-27 23:03   ` Mikulas Patocka
2015-10-27 19:39 ` [PATCH 6/6] dm-stripe: Fix error message Tomohiro Kusumi
2015-10-28 19:51   ` Mike Snitzer [this message]
2015-10-28 20:40     ` Tomohiro Kusumi
2015-10-28 22:00       ` Mike Snitzer
2015-10-29 11:36         ` Tomohiro Kusumi
2015-10-27 23:04 ` [PATCH 1/6] dm-delay: Use DM_MAPIO_XXX macros instead of 0/1 (resend) Mikulas Patocka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151028195128.GA22241@redhat.com \
    --to=snitzer@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=kusumi.tomohiro@gmail.com \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.