From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com ([66.111.4.28]:42478 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755970AbbJ1XHO (ORCPT ); Wed, 28 Oct 2015 19:07:14 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 7780020A90 for ; Wed, 28 Oct 2015 19:07:13 -0400 (EDT) Date: Thu, 29 Oct 2015 08:07:09 +0900 From: Greg KH To: Ioana Ciornei Cc: linux-iio@vger.kernel.org, outreachy-kernel , Cristina Georgiana Opriceana Subject: Re: [Outreachy kernel] [PATCH] staging: iio: dummy: complete IIO events delivery to userspace Message-ID: <20151028230709.GA28617@kroah.com> References: <1445971256-22474-1-git-send-email-ciorneiioana@gmail.com> <20151028224722.GA31531@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Thu, Oct 29, 2015 at 12:49:28AM +0200, Ioana Ciornei wrote: > On Thu, Oct 29, 2015 at 12:47 AM, Greg KH wrote: > > On Tue, Oct 27, 2015 at 08:40:56PM +0200, Ioana Ciornei wrote: > >> Starting with commit fd2bb310ca (Staging: iio: Move evgen interrupt > >> generation to irq_work) event processing is handled by calling > >> both the top half and the threaded part properly simulating real > >> hardware interrupts making use of threaded interrupts. > >> This way the processing is split in 2 parts: > >> > >> * the IRQ handler that runs in IRQ context and only saves the event > >> timestamp > >> * the threaded handler that runs in process context, reads the events > >> and pushes the in the userspace. > >> > >> If the IRQ handler returns IRQ_HANDLED the threaded handler is not > >> even being called since the interrupt is considered to be processed. > >> Because the iio dummy driver processes the events in the threaded > >> handler the IRQ handler must return IRQ_WAKE_THREAD so that the > >> threaded part would be awakened and called. > >> > >> Signed-off-by: Ioana Ciornei > >> Fixes: fd2bb310ca ("Staging: iio: Move evgen interrupt generation to irq_work") > >> Acked-by: Daniel Baluta > >> --- > >> rebased on linux-iio tree > > > > Daniel, can you forward this to the iio developers, I can't take this as > > it doesn't apply to my tree :( > > > > I already sent it to the linux-iio list as Daniel suggested in a > previous message. > I hope it's ok. Fine with me, thanks.