From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22a.google.com (mail-wm0-x22a.google.com. [2a00:1450:400c:c09::22a]) by gmr-mx.google.com with ESMTPS id t18si195102wme.0.2015.10.29.01.08.38 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Oct 2015 01:08:38 -0700 (PDT) Received: by mail-wm0-x22a.google.com with SMTP id l128so19982411wml.0 for ; Thu, 29 Oct 2015 01:08:38 -0700 (PDT) Date: Thu, 29 Oct 2015 08:08:35 +0000 From: Lee Jones To: Alim Akhtar Cc: broonie@kernel.org, k.kozlowski@samsung.com, linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Thomas Abraham Subject: [rtc-linux] Re: [PATCH v4 3/4] regulator: s2mps11: add support for S2MPS15 regulators Message-ID: <20151029080835.GM4058@x1> References: <1446094723-6212-1-git-send-email-alim.akhtar@samsung.com> <1446094723-6212-4-git-send-email-alim.akhtar@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <1446094723-6212-4-git-send-email-alim.akhtar@samsung.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Thu, 29 Oct 2015, Alim Akhtar wrote: > From: Thomas Abraham >=20 > The S2MPS15 PMIC is similar in functionality to S2MPS11/14 PMIC. It conta= ins > 27 LDO and 10 Buck regulators and allows programming these regulators via= a > I2C interface. This patch adds initial support for LDO/Buck regulators of > S2MPS15 PMIC. >=20 > Signed-off-by: Thomas Abraham > Signed-off-by: Alim Akhtar > Reviewed-by: Krzysztof Kozlowski > --- > drivers/regulator/Kconfig | 4 +- > drivers/regulator/s2mps11.c | 135 +++++++++++++++++++++++++++++++++++++= +++++- > 2 files changed, 136 insertions(+), 3 deletions(-) [...] > @@ -1070,6 +1202,7 @@ static const struct platform_device_id s2mps11_pmic= _id[] =3D { > { "s2mps11-pmic", S2MPS11X}, > { "s2mps13-pmic", S2MPS13X}, > { "s2mps14-pmic", S2MPS14X}, > + { "s2mps15-regulator", S2MPS15X}, > { "s2mpu02-pmic", S2MPU02}, > { }, > }; Are you going to s/pmic/regulator/ for the existing devices too? [...] --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog --=20 --=20 You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. ---=20 You received this message because you are subscribed to the Google Groups "= rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v4 3/4] regulator: s2mps11: add support for S2MPS15 regulators Date: Thu, 29 Oct 2015 08:08:35 +0000 Message-ID: <20151029080835.GM4058@x1> References: <1446094723-6212-1-git-send-email-alim.akhtar@samsung.com> <1446094723-6212-4-git-send-email-alim.akhtar@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wm0-f52.google.com ([74.125.82.52]:37214 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750889AbbJ2IIj (ORCPT ); Thu, 29 Oct 2015 04:08:39 -0400 Received: by wmff134 with SMTP id f134so20099468wmf.0 for ; Thu, 29 Oct 2015 01:08:38 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1446094723-6212-4-git-send-email-alim.akhtar@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Alim Akhtar Cc: broonie@kernel.org, k.kozlowski@samsung.com, linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Thomas Abraham On Thu, 29 Oct 2015, Alim Akhtar wrote: > From: Thomas Abraham >=20 > The S2MPS15 PMIC is similar in functionality to S2MPS11/14 PMIC. It c= ontains > 27 LDO and 10 Buck regulators and allows programming these regulators= via a > I2C interface. This patch adds initial support for LDO/Buck regulator= s of > S2MPS15 PMIC. >=20 > Signed-off-by: Thomas Abraham > Signed-off-by: Alim Akhtar > Reviewed-by: Krzysztof Kozlowski > --- > drivers/regulator/Kconfig | 4 +- > drivers/regulator/s2mps11.c | 135 +++++++++++++++++++++++++++++++++= +++++++++- > 2 files changed, 136 insertions(+), 3 deletions(-) [...] > @@ -1070,6 +1202,7 @@ static const struct platform_device_id s2mps11_= pmic_id[] =3D { > { "s2mps11-pmic", S2MPS11X}, > { "s2mps13-pmic", S2MPS13X}, > { "s2mps14-pmic", S2MPS14X}, > + { "s2mps15-regulator", S2MPS15X}, > { "s2mpu02-pmic", S2MPU02}, > { }, > }; Are you going to s/pmic/regulator/ for the existing devices too? [...] --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog