From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Shivani Bhardwaj <shivanib134@gmail.com>
Cc: outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] [PATCH 2/2] Staging: lustre: console: Remove irrelevant return statement
Date: Thu, 29 Oct 2015 16:16:52 +0530 [thread overview]
Message-ID: <20151029104652.GC1331@sudip-pc> (raw)
In-Reply-To: <CAKHNQQE=hZL1yAULMiCj332R6qRW0KtfufTdG3yQzuGH-0T55w@mail.gmail.com>
On Thu, Oct 29, 2015 at 11:30:17AM +0530, Shivani Bhardwaj wrote:
> On Thu, Oct 29, 2015 at 11:29 AM, Shivani Bhardwaj <shivanib134@gmail.com>
> wrote:
>
> >
> >
> > On Thu, Oct 29, 2015 at 11:27 AM, Sudip Mukherjee <
> > sudipm.mukherjee@gmail.com> wrote:
> >
> >> On Thu, Oct 29, 2015 at 11:24:59AM +0530, Shivani Bhardwaj wrote:
> >> > On Thu, Oct 29, 2015 at 11:18 AM, Sudip Mukherjee <
> >> > sudipm.mukherjee@gmail.com> wrote:
> >> >
> >> > > On Thu, Oct 29, 2015 at 11:02:48AM +0530, Shivani Bhardwaj wrote:
> >> > > > Remove return statement from the function lstcon_group_ndlink_move()
> >> > > > as its return type is void.
> >> > > > Fix checkpatch WARNING: void function return statements are not
> >> > > > generally useful
> >> > > >
> >> > > > Signed-off-by : Shivani Bhardwaj <shivanib134@gmail.com>
> >> > >
> >> > > checkpatch is complaining about the "Signed-off-by" because of an
> >> > > extra space.
> >> > >
> >> > > regards
> >> > > sudip
> >> > >
> >> >
> >> > Sending this again. I'm sorry.
> >>
> >> BTW, are you adding this manually? Let git add these Signed-off-by and
> >> you do not need to worry about these anymore.
> >>
> >> regards
> >> sudip
> >>
> >
> > I fixed the commit message by git commit --amend. Did I do anything wrong?
> > Thank you
> >
>
> And, should I be sending it again?
I am seeing that you have already sent it, but I think Greg will be
confused by that patch.
regards
sudip
prev parent reply other threads:[~2015-10-29 10:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 5:31 [PATCH 0/2] Remove unnecessary functions and clean up the code Shivani Bhardwaj
2015-10-29 5:32 ` [PATCH 1/2] Staging: lustre: console: Drop unnecessary wrapper function Shivani Bhardwaj
2015-10-29 5:32 ` [PATCH 2/2] Staging: lustre: console: Remove irrelevant return statement Shivani Bhardwaj
2015-10-29 5:48 ` [Outreachy kernel] " Sudip Mukherjee
2015-10-29 5:54 ` Shivani Bhardwaj
2015-10-29 5:57 ` Sudip Mukherjee
2015-10-29 5:59 ` Shivani Bhardwaj
2015-10-29 6:00 ` Shivani Bhardwaj
2015-10-29 10:46 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151029104652.GC1331@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=shivanib134@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.