From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Date: Thu, 29 Oct 2015 10:48:44 +0000 Subject: Re: [tpmdd-devel] [PATCH] TPM: Avoid reference to potentially freed memory Message-Id: <20151029104844.GA10327@intel.com> List-Id: References: <1445545961-5620-1-git-send-email-christophe.jaillet@wanadoo.fr> <20151023073733.GA6941@intel.com> <20151027102723.GA9120@intel.com> <5631B8B1.9020000@wanadoo.fr> In-Reply-To: <5631B8B1.9020000@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Marion & Christophe JAILLET Cc: kernel-janitors@vger.kernel.org, tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org On Thu, Oct 29, 2015 at 07:12:01AM +0100, Marion & Christophe JAILLET wrote: >=20 >=20 > Le 27/10/2015 11:27, Jarkko Sakkinen a =E9crit : > >On Fri, Oct 23, 2015 at 10:37:33AM +0300, Jarkko Sakkinen wrote: > >>On Thu, Oct 22, 2015 at 10:32:41PM +0200, Christophe JAILLET wrote: > >>>Reference to the 'np' node is dropped before dereferencing the 'sizep'= and > >>>'basep' pointers, which could by then point to junk if the node has be= en > >>>freed. > >>> > >>>Refactor code to call 'of_node_pup' later. > >>> > >>>Signed-off-by: Christophe JAILLET > >>LGTM. > >Is there anyone able to provide Tested-by for this? > > > >Christophe, were you able to reproduce the crash (insmod/rmmod couple > >of times maybe?) and validate that it was gone after fixing the bug? >=20 > Hi, > no, I never triggered the bug. > This is just something noticed while looking at potential issues related = to > incorrect use of 'of_node_pup'. > I only compile tested the patch. The fix is so obvious that I see no reason not to include it. Thanks for the good work. > Best regards, > CJ /Jarkko -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756252AbbJ2Kst (ORCPT ); Thu, 29 Oct 2015 06:48:49 -0400 Received: from mga01.intel.com ([192.55.52.88]:43266 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750927AbbJ2Kss (ORCPT ); Thu, 29 Oct 2015 06:48:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,213,1444719600"; d="scan'208";a="674213410" Date: Thu, 29 Oct 2015 12:48:44 +0200 From: Jarkko Sakkinen To: Marion & Christophe JAILLET Cc: kernel-janitors@vger.kernel.org, tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [tpmdd-devel] [PATCH] TPM: Avoid reference to potentially freed memory Message-ID: <20151029104844.GA10327@intel.com> References: <1445545961-5620-1-git-send-email-christophe.jaillet@wanadoo.fr> <20151023073733.GA6941@intel.com> <20151027102723.GA9120@intel.com> <5631B8B1.9020000@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5631B8B1.9020000@wanadoo.fr> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2015 at 07:12:01AM +0100, Marion & Christophe JAILLET wrote: > > > Le 27/10/2015 11:27, Jarkko Sakkinen a écrit : > >On Fri, Oct 23, 2015 at 10:37:33AM +0300, Jarkko Sakkinen wrote: > >>On Thu, Oct 22, 2015 at 10:32:41PM +0200, Christophe JAILLET wrote: > >>>Reference to the 'np' node is dropped before dereferencing the 'sizep' and > >>>'basep' pointers, which could by then point to junk if the node has been > >>>freed. > >>> > >>>Refactor code to call 'of_node_pup' later. > >>> > >>>Signed-off-by: Christophe JAILLET > >>LGTM. > >Is there anyone able to provide Tested-by for this? > > > >Christophe, were you able to reproduce the crash (insmod/rmmod couple > >of times maybe?) and validate that it was gone after fixing the bug? > > Hi, > no, I never triggered the bug. > This is just something noticed while looking at potential issues related to > incorrect use of 'of_node_pup'. > I only compile tested the patch. The fix is so obvious that I see no reason not to include it. Thanks for the good work. > Best regards, > CJ /Jarkko