Re: [Outreachy kernel] [PATCH] Staging: lustre: rpc: Remove unnecessary wrapper function

[Sudip Mukherjee <sudipm.mukherjee@gmail.com>]

On Thu, Oct 29, 2015 at 11:52:23AM +0530, Shivani Bhardwaj wrote:
> Remove the function srpc_post_active_rqtbuf() and replace its only call
> with the function srpc_post_active_rdma() by adding and typecasting the
> appropriate parameters.
> 
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
>  drivers/staging/lustre/lnet/selftest/rpc.c | 17 +++++------------
>  1 file changed, 5 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lnet/selftest/rpc.c b/drivers/staging/lustre/lnet/selftest/rpc.c
> index 162f9d3..cb895c3 100644
> --- a/drivers/staging/lustre/lnet/selftest/rpc.c
> +++ b/drivers/staging/lustre/lnet/selftest/rpc.c
> @@ -445,15 +445,6 @@ srpc_post_active_rdma(int portal, __u64 matchbits, void *buf, int len,
>  }
>  
>  static int
> -srpc_post_active_rqtbuf(lnet_process_id_t peer, int service, void *buf,
> -			int len, lnet_handle_md_t *mdh, srpc_event_t *ev)
> -{
> -	return srpc_post_active_rdma(srpc_serv_portal(service), service,
> -				     buf, len, LNET_MD_OP_PUT, peer,
> -				     LNET_NID_ANY, mdh, ev);
> -}
> -
> -static int
>  srpc_post_passive_rqtbuf(int service, int local, void *buf, int len,
>  			 lnet_handle_md_t *mdh, srpc_event_t *ev)
>  {
> @@ -798,9 +789,11 @@ srpc_send_request(srpc_client_rpc_t *rpc)
>  	ev->ev_data  = rpc;
>  	ev->ev_type  = SRPC_REQUEST_SENT;
>  
> -	rc = srpc_post_active_rqtbuf(rpc->crpc_dest, rpc->crpc_service,
> -				     &rpc->crpc_reqstmsg, sizeof(srpc_msg_t),
> -				     &rpc->crpc_reqstmdh, ev);
> +	rc = srpc_post_active_rdma(srpc_serv_portal(rpc->crpc_service),
> +				   rpc->crpc_service, &rpc->crpc_reqstmsg,
> +				   sizeof(srpc_msg_t), LNET_MD_OP_PUT,
> +				   (lnet_process_id_t)rpc->crpc_dest,

why do you need the typecast to lnet_process_id_t?

crpc_dest is already of the type lnet_process_id_t.
check lustre/lnet/selftest/selftest.h file.

regards
sudip