Re: [Qemu-devel] [PATCH] monitor: Plug memory leak on QMP error

[Luiz Capitulino <lcapitulino@redhat.com>]

On Thu, 29 Oct 2015 12:15:09 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> Leak introduced in commit 8a4f501..710aec9, v2.4.0.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>

I think this can go through your tree?

> ---
>  monitor.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/monitor.c b/monitor.c
> index 301a143..c59e85b 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -3862,6 +3862,7 @@ static void handle_qmp_command(JSONMessageParser *parser, QList *tokens)
>  err_out:
>      monitor_protocol_emitter(mon, data, local_err);
>      qobject_decref(data);
> +    error_free(local_err);
>      QDECREF(input);
>      QDECREF(args);
>  }