From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] iotests: Do not suppress segfaults in bash tests
Date: Thu, 29 Oct 2015 15:57:17 +0100 [thread overview]
Message-ID: <20151029145717.GD3854@noname.redhat.com> (raw)
In-Reply-To: <1441047913-30596-2-git-send-email-mreitz@redhat.com>
Am 31.08.2015 um 21:05 hat Max Reitz geschrieben:
> Currently, if a qemu/qemu-io/qemu-img/qemu-nbd invocation receives a
> segmentation fault, that message is invisible in most cases since the
> output is generally filtered and bash suppresses the segmentation fault
> notice for any but the last element of a pipe.
>
> Most of the time, the test will then fail anyway because of missing
> output, but not necessarily (as happened with test 82 recently).
>
> Fix this by making the corresponding environment variables point to
> wrapper functions which execute the respective command in a subshell.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
This patch seems to have broken -valgrind.
Kevin
next prev parent reply other threads:[~2015-10-29 14:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 19:05 [Qemu-devel] [PATCH 0/2] iotests: Emit signal-kill messages Max Reitz
2015-08-31 19:05 ` [Qemu-devel] [PATCH 1/2] iotests: Do not suppress segfaults in bash tests Max Reitz
2015-08-31 22:55 ` [Qemu-devel] [Qemu-block] " Jeff Cody
2015-09-02 15:09 ` Max Reitz
2015-09-02 15:30 ` Jeff Cody
2015-10-29 14:57 ` Kevin Wolf [this message]
2015-10-29 18:05 ` Jeff Cody
2015-08-31 19:05 ` [Qemu-devel] [PATCH 2/2] iotests: Warn if python subprocess is killed Max Reitz
2015-09-08 21:25 ` [Qemu-devel] [Qemu-block] " John Snow
2015-09-08 21:29 ` Max Reitz
2015-09-08 21:37 ` John Snow
2015-09-08 21:38 ` Max Reitz
2015-09-08 21:42 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151029145717.GD3854@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.