From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zrra5-0004uM-Dc for qemu-devel@nongnu.org; Thu, 29 Oct 2015 14:05:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zrra4-0001A0-Mu for qemu-devel@nongnu.org; Thu, 29 Oct 2015 14:05:45 -0400 Date: Thu, 29 Oct 2015 14:05:36 -0400 From: Jeff Cody Message-ID: <20151029180536.GB2628@localhost.localdomain> References: <1441047913-30596-1-git-send-email-mreitz@redhat.com> <1441047913-30596-2-git-send-email-mreitz@redhat.com> <20151029145717.GD3854@noname.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151029145717.GD3854@noname.redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] iotests: Do not suppress segfaults in bash tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz On Thu, Oct 29, 2015 at 03:57:17PM +0100, Kevin Wolf wrote: > Am 31.08.2015 um 21:05 hat Max Reitz geschrieben: > > Currently, if a qemu/qemu-io/qemu-img/qemu-nbd invocation receives a > > segmentation fault, that message is invisible in most cases since the > > output is generally filtered and bash suppresses the segmentation fault > > notice for any but the last element of a pipe. > > > > Most of the time, the test will then fail anyway because of missing > > output, but not necessarily (as happened with test 82 recently). > > > > Fix this by making the corresponding environment variables point to > > wrapper functions which execute the respective command in a subshell. > > > > Signed-off-by: Max Reitz > > This patch seems to have broken -valgrind. > Hi Kevin, I just submitted another patch to fix this issue ("qemu-iotests: fix -valgrind option for check") Thanks, Jeff