From: Peng Fan <b51431@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] common: simply code
Date: Fri, 30 Oct 2015 10:49:37 +0800 [thread overview]
Message-ID: <20151030024935.GA7834@shlinux2> (raw)
In-Reply-To: <CAPnjgZ1dDK1kUU+g49SL2Bow9vK8Q7i+juU7CZ-fZJt4t1ksUw@mail.gmail.com>
On Thu, Oct 29, 2015 at 11:15:51AM -0600, Simon Glass wrote:
>On 29 October 2015 at 01:57, Peng Fan <Peng.Fan@freescale.com> wrote:
>> get_clocks is wrapped by CONFIG_FSL_CLK and CONFIG_M68K in seperate
>> piece code. They can be merged into one snippet.
>>
>> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
>> Cc: Tom Rini <trini@konsulko.com>
>> Cc: Simon Glass <sjg@chromium.org>
>> Cc: Bin Meng <bmeng.cn@gmail.com>
>> Cc: Alexey Brodkin <abrodkin@synopsys.com>
>> Cc: "angelo at sysam.it" <angelo@sysam.it>
>> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
>> Cc: Stephen Warren <swarren@nvidia.com>
>> Cc: "Andreas Bie?mann" <andreas.devel@googlemail.com>
>> ---
>> common/board_f.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>nit: I think it would be better to use a subject like "common:
>Simplify get_clocks() #ifdef".
Thanks, will take your suggestion and send out v2.
Regards,
Peng.
>
>Reviewed-by: Simon Glass <sjg@chromium.org>
--
prev parent reply other threads:[~2015-10-30 2:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 7:57 [U-Boot] [PATCH] common: simply code Peng Fan
2015-10-29 17:15 ` Simon Glass
2015-10-30 2:49 ` Peng Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151030024935.GA7834@shlinux2 \
--to=b51431@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.