All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: ross.zwisler@linux.intel.com, jack@suse.cz, xfs@oss.sgi.com
Subject: Re: [PATCH 4/6] xfs: DAX does not use IO completion callbacks
Date: Fri, 30 Oct 2015 08:37:04 -0400	[thread overview]
Message-ID: <20151030123704.GD54905@bfoster.bfoster> (raw)
In-Reply-To: <20151029233911.GT19199@dastard>

On Fri, Oct 30, 2015 at 10:39:11AM +1100, Dave Chinner wrote:
> On Thu, Oct 29, 2015 at 10:29:57AM -0400, Brian Foster wrote:
> > On Mon, Oct 19, 2015 at 02:27:16PM +1100, Dave Chinner wrote:
> > > From: Dave Chinner <dchinner@redhat.com>
> > > 
> > > For DAX, we are now doing block zeroing and
> > > we are updating the file size during allocation. This means we no
> > > longer need an IO completion callback to do these things, so remove
> > > the completion callbacks from the __dax_fault and __dax_mkwrite
> > > calls.
> > > 
> > 
> > Where do we "update the file size during allocation?"
> 
> Stale comment. For page faults, we'll never update the file size
> (segv if fault is beyond EOF), and DIO still does IO completion
> based file size updates.
> 

Ok. With that fixed up:

Reviewed-by: Brian Foster <bfoster@redhat.com>

> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@fromorbit.com
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2015-10-30 12:37 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19  3:27 [PATCH 0/6 V2] xfs: upfront block zeroing for DAX Dave Chinner
2015-10-19  3:27 ` [PATCH 1/6] xfs: fix inode size update overflow in xfs_map_direct() Dave Chinner
2015-10-29 14:27   ` Brian Foster
2015-10-19  3:27 ` [PATCH 2/6] xfs: introduce BMAPI_ZERO for allocating zeroed extents Dave Chinner
2015-10-29 14:27   ` Brian Foster
2015-10-29 23:35     ` Dave Chinner
2015-10-30 12:36       ` Brian Foster
2015-11-02  1:21         ` Dave Chinner
2015-10-19  3:27 ` [PATCH 3/6] xfs: Don't use unwritten extents for DAX Dave Chinner
2015-10-29 14:29   ` Brian Foster
2015-10-29 23:37     ` Dave Chinner
2015-10-30 12:36       ` Brian Foster
2015-11-02  1:14         ` Dave Chinner
2015-11-02 14:15           ` Brian Foster
2015-11-02 21:44             ` Dave Chinner
2015-11-02 21:44               ` Dave Chinner
2015-11-02 21:44               ` Dave Chinner
2015-11-03  3:53               ` Dan Williams
2015-11-03  3:53                 ` Dan Williams
2015-11-03  3:53                 ` Dan Williams
2015-11-03  5:04                 ` Dave Chinner
2015-11-03  5:04                   ` Dave Chinner
2015-11-04  0:50                   ` Ross Zwisler
2015-11-04  0:50                     ` Ross Zwisler
2015-11-04  1:02                     ` Dan Williams
2015-11-04  1:02                       ` Dan Williams
2015-11-04  4:46                       ` Ross Zwisler
2015-11-04  4:46                         ` Ross Zwisler
2015-11-04  9:06                         ` Jan Kara
2015-11-04  9:06                           ` Jan Kara
2015-11-04 15:35                           ` Ross Zwisler
2015-11-04 15:35                             ` Ross Zwisler
2015-11-04 17:21                             ` Jan Kara
2015-11-04 17:21                               ` Jan Kara
2015-11-03  9:16               ` Jan Kara
2015-11-03  9:16                 ` Jan Kara
2015-10-19  3:27 ` [PATCH 4/6] xfs: DAX does not use IO completion callbacks Dave Chinner
2015-10-29 14:29   ` Brian Foster
2015-10-29 23:39     ` Dave Chinner
2015-10-30 12:37       ` Brian Foster [this message]
2015-10-19  3:27 ` [PATCH 5/6] xfs: add ->pfn_mkwrite support for DAX Dave Chinner
2015-10-29 14:30   ` Brian Foster
2015-10-19  3:27 ` [PATCH 6/6] xfs: xfs_filemap_pmd_fault treats read faults as write faults Dave Chinner
2015-10-29 14:30   ` Brian Foster
2015-11-05 23:48 ` [PATCH 0/6 V2] xfs: upfront block zeroing for DAX Ross Zwisler
2015-11-06 22:32   ` Dave Chinner
2015-11-06 18:12 ` Boylston, Brian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151030123704.GD54905@bfoster.bfoster \
    --to=bfoster@redhat.com \
    --cc=david@fromorbit.com \
    --cc=jack@suse.cz \
    --cc=ross.zwisler@linux.intel.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.