From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v5 5/5] gpio: tps65912: Add GPIO driver for the TPS65912 PMIC Date: Fri, 30 Oct 2015 17:10:45 +0000 Message-ID: <20151030171045.GA4058@x1> References: <1446161922-8755-1-git-send-email-afd@ti.com> <1446161922-8755-6-git-send-email-afd@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Walleij Cc: "Andrew F. Davis" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Alexandre Courbot , Samuel Ortiz , Liam Girdwood , Mark Brown , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-gpio@vger.kernel.org On Fri, 30 Oct 2015, Linus Walleij wrote: > On Fri, Oct 30, 2015 at 12:38 AM, Andrew F. Davis wrote: >=20 > > This patch adds support for the TPS65912 PMIC GPIOs. > > > > TPS65912 has five configurable GPIOs that can be used for several > > purposes. > > > > Signed-off-by: Andrew F. Davis >=20 > This looks like a fine driver, can't really see anything wrong with i= t so: > Reviewed-by: Linus Walleij >=20 > > +#define to_tps65912_gpio(gc) container_of(gc, struct tps65912_gpio= , gpio_chip) >=20 > I would rewrite that to static inline however. >=20 > Lee can take this into the MFD tree with my review-tag if he wants. Please fix this, then resubmit the set with Acks/Reviewed-by's applied. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759673AbbJ3RKw (ORCPT ); Fri, 30 Oct 2015 13:10:52 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:34640 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759575AbbJ3RKu (ORCPT ); Fri, 30 Oct 2015 13:10:50 -0400 Date: Fri, 30 Oct 2015 17:10:45 +0000 From: Lee Jones To: Linus Walleij Cc: "Andrew F. Davis" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Alexandre Courbot , Samuel Ortiz , Liam Girdwood , Mark Brown , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v5 5/5] gpio: tps65912: Add GPIO driver for the TPS65912 PMIC Message-ID: <20151030171045.GA4058@x1> References: <1446161922-8755-1-git-send-email-afd@ti.com> <1446161922-8755-6-git-send-email-afd@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 Oct 2015, Linus Walleij wrote: > On Fri, Oct 30, 2015 at 12:38 AM, Andrew F. Davis wrote: > > > This patch adds support for the TPS65912 PMIC GPIOs. > > > > TPS65912 has five configurable GPIOs that can be used for several > > purposes. > > > > Signed-off-by: Andrew F. Davis > > This looks like a fine driver, can't really see anything wrong with it so: > Reviewed-by: Linus Walleij > > > +#define to_tps65912_gpio(gc) container_of(gc, struct tps65912_gpio, gpio_chip) > > I would rewrite that to static inline however. > > Lee can take this into the MFD tree with my review-tag if he wants. Please fix this, then resubmit the set with Acks/Reviewed-by's applied. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog