From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Shraddha Barke <shraddha.6596@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2 1/2] Staging: sm750fb: Remove unused modedb.h file
Date: Sat, 31 Oct 2015 12:26:59 +0530 [thread overview]
Message-ID: <20151031065659.GB5145@sudip-pc> (raw)
In-Reply-To: <1446213783-30267-2-git-send-email-shraddha.6596@gmail.com>
On Fri, Oct 30, 2015 at 07:33:02PM +0530, Shraddha Barke wrote:
> The header file modedb.h is only included in sm750.c but the things
> defined by modedb.h are not used anywhere in sm750.c. Thus, drop
> the include in sm750.c and modedb.h can be dropped completely.
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
In the original out of tree vendor code this modedb.h was used as:
#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,10)
pdb[i] = &modedb2[0];
cdb[i] = nmodedb2;
#endif
But not required here.
Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
regards
sudip
next prev parent reply other threads:[~2015-10-31 6:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 14:03 [PATCH v2 0/2] Staging: Remove unused header files Shraddha Barke
2015-10-30 14:03 ` [PATCH v2 1/2] Staging: sm750fb: Remove unused modedb.h file Shraddha Barke
2015-10-31 6:56 ` Sudip Mukherjee [this message]
2015-10-30 14:03 ` [PATCH v2 2/2] Staging: dgnc: Remove unused #include header file Shraddha Barke
2015-10-30 14:04 ` [Outreachy kernel] [PATCH v2 0/2] Staging: Remove unused header files Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151031065659.GB5145@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.