From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Amarjargal Gundjalam <amarjargal.gundjalam@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2 3/5] staging: media: bcm2048: remove unnecessary blank lines
Date: Sat, 31 Oct 2015 12:55:08 +0530 [thread overview]
Message-ID: <20151031072508.GC5145@sudip-pc> (raw)
In-Reply-To: <27b9f66c39d5cd3e32f01cc09acec7ddd0c33cca.1446235583.git.amarjargal.gundjalam@gmail.com>
On Fri, Oct 30, 2015 at 01:21:05PM -0700, Amarjargal Gundjalam wrote:
> This patch fixes the checkpatch issues:
>
> CHECK: Please don't use multiple blank lines
> CHECK: Blank lines aren't necessary after an open brace '{'
>
> Signed-off-by: Amarjargal Gundjalam <amarjargal.gundjalam@gmail.com>
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index e65c83c..f8578fb 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -179,7 +179,6 @@
> #define BCM2048_DEFAULT_TIMEOUT 1500
> #define BCM2048_AUTO_SEARCH_TIMEOUT 3000
>
> -
> #define BCM2048_FREQDEV_UNIT 10000
> #define BCM2048_FREQV4L2_MULTI 625
> #define dev_to_v4l2(f) ((f * BCM2048_FREQDEV_UNIT) / BCM2048_FREQV4L2_MULTI)
> @@ -1436,10 +1435,8 @@ static void bcm2048_parse_rds_pi(struct bcm2048_device *bdev)
> u16 pi;
>
> for (i = 0; i < bdev->fifo_size; i += BCM2048_RDS_FIFO_DUPLE_SIZE) {
> -
> /* Block A match, only data without crc errors taken */
> if (bdev->rds_info.radio_text[i] == BCM2048_RDS_BLOCK_A) {
> -
> pi = (bdev->rds_info.radio_text[i + 1] << 8) +
> bdev->rds_info.radio_text[i + 2];
>
> @@ -1494,8 +1491,7 @@ static int bcm2048_parse_rt_match_b(struct bcm2048_device *bdev, int i)
> return -EIO;
>
> if ((bdev->rds_info.radio_text[i] & BCM2048_RDS_BLOCK_MASK) ==
> - BCM2048_RDS_BLOCK_B) {
> -
> + BCM2048_RDS_BLOCK_B) {
This is an unrelated change from your commit message. This should have
been included in your 1/5 patch.
regards
sudip
next prev parent reply other threads:[~2015-10-31 7:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 13:00 [PATCH 0/6] staging: media: bcm2048: fix multiple checkpatch issues Amarjargal Gundjalam
2015-10-29 13:00 ` [PATCH 1/6] staging: media: bcm2048: fix code indent for conditional statements Amarjargal Gundjalam
2015-10-29 20:42 ` [Outreachy kernel] " Julia Lawall
2015-10-30 2:39 ` Amarjargal Gundjalam
2015-10-30 6:23 ` Julia Lawall
2015-10-30 6:48 ` Amarjargal Gundjalam
2015-10-30 6:51 ` Julia Lawall
2015-10-30 7:02 ` Amarjargal Gundjalam
2015-10-29 13:00 ` [PATCH 2/6] staging: media: bcm2048: add space around operators Amarjargal Gundjalam
2015-10-29 13:00 ` [PATCH 3/6] staging: media: bcm2048: match alignments with open parenthesis Amarjargal Gundjalam
2015-10-29 13:00 ` [PATCH 4/6] staging: media: bcm2048: remove unnecessary blank lines Amarjargal Gundjalam
2015-10-29 13:00 ` [PATCH 5/6] staging: media: bcm2048: remove unnecessary space after a cast Amarjargal Gundjalam
2015-10-29 13:00 ` [PATCH 6/6] staging: media: bcm2048: fix mispelling Amarjargal Gundjalam
2015-10-30 20:21 ` [PATCH v2 0/5] staging: media: bcm2048: fix multiple checkpatch issues Amarjargal Gundjalam
2015-10-30 20:21 ` [PATCH v2 1/5] staging: media: bcm2048: match alignments with open parenthesis Amarjargal Gundjalam
2015-10-30 20:21 ` [PATCH v2 2/5] staging: media: bcm2048: add space around operators Amarjargal Gundjalam
2015-10-30 20:21 ` [PATCH v2 3/5] staging: media: bcm2048: remove unnecessary blank lines Amarjargal Gundjalam
2015-10-31 7:25 ` Sudip Mukherjee [this message]
2015-10-30 20:21 ` [PATCH v2 4/5] staging: media: bcm2048: remove unnecessary space after a cast Amarjargal Gundjalam
2015-10-30 20:21 ` [PATCH v2 5/5] staging: media: bcm2048: fix mispelling Amarjargal Gundjalam
2015-10-31 8:56 ` [PATCH v3 0/5] staging: media: bcm2048: fix multiple checkpatch issues Amarjargal Gundjalam
2015-10-31 8:56 ` [PATCH v3 1/5] staging: media: bcm2048: match alignments with open parenthesis Amarjargal Gundjalam
2015-10-31 8:56 ` [PATCH v3 2/5] staging: media: bcm2048: add space around operators Amarjargal Gundjalam
2015-10-31 8:56 ` [PATCH v3 3/5] staging: media: bcm2048: remove unnecessary blank lines Amarjargal Gundjalam
2015-10-31 8:56 ` [PATCH v3 4/5] staging: media: bcm2048: remove unnecessary space after a cast Amarjargal Gundjalam
2015-10-31 8:56 ` [PATCH v3 5/5] staging: media: bcm2048: fix mispelling Amarjargal Gundjalam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151031072508.GC5145@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=amarjargal.gundjalam@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.