From: Shivani Bhardwaj <shivanib134@gmail.com>
To: outreachy-kernel@googlegroups.com
Subject: [PATCH] Staging: lustre: interval_tree: Convert inline function to macro
Date: Sun, 1 Nov 2015 00:15:44 +0530 [thread overview]
Message-ID: <20151031184544.GA27064@ubuntu> (raw)
Convert the function max_u64() to macro because macros tend to be more
flexible than inline functions and here, the macro is going to be type
safe so there are not going to be any side effects.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
drivers/staging/lustre/lustre/ldlm/interval_tree.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ldlm/interval_tree.c b/drivers/staging/lustre/lustre/ldlm/interval_tree.c
index a2ea8e5..52d0afd 100644
--- a/drivers/staging/lustre/lustre/ldlm/interval_tree.c
+++ b/drivers/staging/lustre/lustre/ldlm/interval_tree.c
@@ -42,6 +42,8 @@
#include "../include/obd_support.h"
#include "../include/interval_tree.h"
+#define max_u64(x, y) ((x > y) ? x : y)
+
enum {
INTERVAL_RED = 0,
INTERVAL_BLACK = 1
@@ -96,11 +98,6 @@ static inline int extent_equal(struct interval_node_extent *e1,
return (e1->start == e2->start) && (e1->end == e2->end);
}
-static inline __u64 max_u64(__u64 x, __u64 y)
-{
- return x > y ? x : y;
-}
-
static struct interval_node *interval_first(struct interval_node *node)
{
if (!node)
--
2.1.0
next reply other threads:[~2015-10-31 18:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-31 18:45 Shivani Bhardwaj [this message]
2015-10-31 18:53 ` [Outreachy kernel] [PATCH] Staging: lustre: interval_tree: Convert inline function to macro Greg KH
2015-10-31 18:54 ` Shivani Bhardwaj
2015-10-31 19:09 ` Julia Lawall
2015-10-31 19:12 ` Shivani Bhardwaj
2015-10-31 19:15 ` Julia Lawall
2015-10-31 19:27 ` Shivani Bhardwaj
2015-10-31 19:36 ` Julia Lawall
2015-10-31 19:38 ` Shivani Bhardwaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151031184544.GA27064@ubuntu \
--to=shivanib134@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.