All of lore.kernel.org
 help / color / mirror / Atom feed
From: arigead@gmail.com (John Whitmore)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Strange warnings out of checkpatch
Date: Sun, 1 Nov 2015 20:19:24 +0000	[thread overview]
Message-ID: <20151101201922.GA7361@bamboo.electronicsoup> (raw)

I'm using the MCP2515 driver chip on some work I'm doing. Out of curiosity I
ran checkpatch.pl on the C file and don't understand the output.

A search sort of seems to suggest that it is a problem with the checkpatch
utility itself. 

http://www.serverphorums.com/read.php?12,1264313

I'd like to understand what is either wrong with code or chcekpatch




$ scripts/checkpatch.pl drivers/net/can/spi/mcp251x.c 
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#727: 
static void mcp251x_error_skb(struct net_device *net, int can_id, int data1)

ERROR: Does not appear to be a unified-diff format patch

total: 1 errors, 1 warnings, 0 lines checked

drivers/net/can/spi/mcp251x.c has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

             reply	other threads:[~2015-11-01 20:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-01 20:19 John Whitmore [this message]
2015-11-01 20:34 ` Strange warnings out of checkpatch Aruna Hewapathirane
2015-11-02 20:11   ` John Whitmore
2015-11-02 20:21     ` Aruna Hewapathirane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151101201922.GA7361@bamboo.electronicsoup \
    --to=arigead@gmail.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.