From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH kernel] rcu: Fix comment for rcu_dereference_raw_notrace
Date: Sun, 1 Nov 2015 19:15:30 -0800 [thread overview]
Message-ID: <20151102031530.GN4122@linux.vnet.ibm.com> (raw)
In-Reply-To: <1446430907-25955-1-git-send-email-aik@ozlabs.ru>
On Mon, Nov 02, 2015 at 01:21:47PM +1100, Alexey Kardashevskiy wrote:
> rcu_dereference_raw() calls indirectly rcu_read_lock_held() while
> rcu_dereference_raw_notrace() does not so fix the comment about the latter.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Good eyes! Queued for 4.5, thank you!
Thanx, Paul
> ---
> include/linux/rcupdate.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
> index 581abf8..931d627 100644
> --- a/include/linux/rcupdate.h
> +++ b/include/linux/rcupdate.h
> @@ -760,7 +760,7 @@ static inline void rcu_preempt_sleep_check(void)
> * The tracing infrastructure traces RCU (we want that), but unfortunately
> * some of the RCU checks causes tracing to lock up the system.
> *
> - * The tracing version of rcu_dereference_raw() must not call
> + * The no-tracing version of rcu_dereference_raw() must not call
> * rcu_read_lock_held().
> */
> #define rcu_dereference_raw_notrace(p) __rcu_dereference_check((p), 1, __rcu)
> --
> 2.5.0.rc3
>
prev parent reply other threads:[~2015-11-02 3:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 2:21 [PATCH kernel] rcu: Fix comment for rcu_dereference_raw_notrace Alexey Kardashevskiy
2015-11-02 3:15 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151102031530.GN4122@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=aik@ozlabs.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.