From: Zidan Wang <zidan.wang@freescale.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: wm8960 sleep time is too long when system suspend
Date: Mon, 2 Nov 2015 18:49:23 +0800 [thread overview]
Message-ID: <20151102104921.GA4769@shlinux2> (raw)
In-Reply-To: <20151102091855.GO10520@ck-lbox>
On Mon, Nov 02, 2015 at 09:18:55AM +0000, Charles Keepax wrote:
> On Mon, Nov 02, 2015 at 04:44:04PM +0800, Zidan Wang wrote:
> > Hi Mark,
> >
> > In wm8960 codec driver, suspend_bias_off has been enabled. So when system suspend, the wm8960 codec will go to bias off,
> > it will disable VMID and VREF, then sleep 600ms. It seems that 600ms is too long for system suspend.
> >
> > Because the wm8960 datasheet don't mentioned the sleep time, so i want to check with you if we can shorten the sleep time.
>
> I can't say that I am explicit familiar with the required delay
> there, but the comment in the code says that we are letting VMID
> and VREF discharge, which I certainly could believe would take a
> while. My guess would be that we likely weren't super excited
> about putting a 600mS delay in, which probably means it was
> necessary for some reason.
>
> How much where you hoping to reduce it by? I can see if I can
> find a hardware engineer who still remembers enough about the
> part to discuss it with.
>
Some customer can't accept such long system suspend time. It's better to spend less than 100ms for system suspend.
Codec suspend is a part of system suspend, so it should be less than 100ms, and as short as possible.
Best Regards,
Zidan Wang
> Thanks,
> Charles
next prev parent reply other threads:[~2015-11-02 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 8:44 wm8960 sleep time is too long when system suspend Zidan Wang
2015-11-02 9:18 ` Charles Keepax
2015-11-02 10:49 ` Zidan Wang [this message]
2015-11-02 11:16 ` Mark Brown
2015-11-02 11:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151102104921.GA4769@shlinux2 \
--to=zidan.wang@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.