From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Robert Fekete <robert.fekete@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm: Describe the Rotation property bits.
Date: Mon, 2 Nov 2015 17:18:36 +0200 [thread overview]
Message-ID: <20151102151836.GL4437@intel.com> (raw)
In-Reply-To: <1446477248-19131-1-git-send-email-robert.fekete@linux.intel.com>
On Mon, Nov 02, 2015 at 04:14:08PM +0100, Robert Fekete wrote:
> Adds clarification of the rotation property bits. I.e. rotation is
> counter clockwise and that reflects are applied before any rotation.
>
> v2: Refer to the define names instead of the property values.
>
> Signed-off-by: Robert Fekete <robert.fekete@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> include/drm/drm_crtc.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index 3f0c6909dda1..f47cefa37ef3 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -85,7 +85,11 @@ static inline uint64_t I642U64(int64_t val)
> return (uint64_t)*((uint64_t *)&val);
> }
>
> -/* rotation property bits */
> +/*
> + * Rotation property bits. DRM_ROTATE_<degrees> rotates the image by the
> + * specified amount in degrees in counter clockwise direction. DRM_REFLECT_X and
> + * DRM_REFLECT_Y reflects the image along the specified axis prior to rotation
> + */
> #define DRM_ROTATE_MASK 0x0f
> #define DRM_ROTATE_0 0
> #define DRM_ROTATE_90 1
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-11-02 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 15:14 [PATCH v2] drm: Describe the Rotation property bits Robert Fekete
2015-11-02 15:18 ` Ville Syrjälä [this message]
2015-11-16 16:10 ` [Intel-gfx] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151102151836.GL4437@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=robert.fekete@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.