From: Peter Zijlstra <peterz@infradead.org>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v3 1/2] cputime: fix invalid gtime in proc
Date: Mon, 2 Nov 2015 17:13:51 +0100 [thread overview]
Message-ID: <20151102161351.GT3604@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD05F575AA@BPXM14GP.gisp.nec.co.jp>
On Fri, Oct 30, 2015 at 12:46:39AM +0000, Hiroshi Shimamoto wrote:
> +++ b/kernel/sched/cputime.c
> @@ -786,6 +786,9 @@ cputime_t task_gtime(struct task_struct *t)
> unsigned int seq;
> cputime_t gtime;
>
> + if (!context_tracking_is_enabled())
> + return t->gtime;
> +
Yeah, not happy about that.. why do we have to touch context tracking
muck to find vtime state etc.
> do {
> seq = read_seqbegin(&t->vtime_seqlock);
>
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2015-11-02 16:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 0:46 [PATCH v3 1/2] cputime: fix invalid gtime in proc Hiroshi Shimamoto
2015-11-02 16:13 ` Peter Zijlstra [this message]
2015-11-04 16:14 ` Frederic Weisbecker
2015-11-10 8:43 ` Hiroshi Shimamoto
2015-11-13 15:33 ` Frederic Weisbecker
2015-11-13 16:10 ` Peter Zijlstra
2015-11-13 16:14 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151102161351.GT3604@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=fweisbec@gmail.com \
--cc=h-shimamoto@ct.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.