From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6212594982457442304 X-Received: by 10.67.7.35 with SMTP id cz3mr19123269pad.40.1446483551569; Mon, 02 Nov 2015 08:59:11 -0800 (PST) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.50.119.8 with SMTP id kq8ls785477igb.28.gmail; Mon, 02 Nov 2015 08:59:11 -0800 (PST) X-Received: by 10.67.7.35 with SMTP id cz3mr19123244pad.40.1446483551202; Mon, 02 Nov 2015 08:59:11 -0800 (PST) Return-Path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by gmr-mx.google.com with ESMTPS id iz5si1856711pbc.2.2015.11.02.08.59.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Nov 2015 08:59:11 -0800 (PST) Received-SPF: pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) client-ip=140.211.169.12; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Received: from localhost (c-50-170-35-168.hsd1.wa.comcast.net [50.170.35.168]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id D691C8DD; Mon, 2 Nov 2015 16:59:10 +0000 (UTC) Date: Mon, 2 Nov 2015 08:59:10 -0800 From: Greg KH To: Shivani Bhardwaj Cc: outreachy-kernel Subject: Re: [Outreachy kernel] [PATCH] Staging: lustre: linux-cpu: Remove unnecessary wrapper functions Message-ID: <20151102165910.GA21152@kroah.com> References: <20151102164119.GA32817@ubuntu> <20151102165223.GA12839@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) On Mon, Nov 02, 2015 at 10:26:18PM +0530, Shivani Bhardwaj wrote: > On Mon, Nov 2, 2015 at 10:22 PM, Greg KH wrote: > > On Mon, Nov 02, 2015 at 10:11:19PM +0530, Shivani Bhardwaj wrote: > >> Remove the functions cfs_cpu_core_siblings(), cfs_cpu_ht_siblings(), > >> cfs_node_to_cpumask() and replace their calls with the functions they > >> wrapped. > >> > >> Signed-off-by: Shivani Bhardwaj > >> --- > >> .../staging/lustre/lustre/libcfs/linux/linux-cpu.c | 30 +++++----------------- > >> 1 file changed, 7 insertions(+), 23 deletions(-) > >> > >> diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-cpu.c b/drivers/staging/lustre/lustre/libcfs/linux/linux-cpu.c > >> index 2097364..31719af 100644 > >> --- a/drivers/staging/lustre/lustre/libcfs/linux/linux-cpu.c > >> +++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-cpu.c > >> @@ -78,23 +78,6 @@ struct cfs_cpt_data { > >> > >> static struct cfs_cpt_data cpt_data; > >> > >> -static void cfs_cpu_core_siblings(int cpu, cpumask_t *mask) > >> -{ > >> - /* return cpumask of cores in the same socket */ > >> - cpumask_copy(mask, topology_core_cpumask(cpu)); > >> -} > >> - > >> -/* return cpumask of HTs in the same core */ > >> -static void cfs_cpu_ht_siblings(int cpu, cpumask_t *mask) > >> -{ > >> - cpumask_copy(mask, topology_sibling_cpumask(cpu)); > >> -} > >> - > >> -static void cfs_node_to_cpumask(int node, cpumask_t *mask) > >> -{ > >> - cpumask_copy(mask, cpumask_of_node(node)); > >> -} > >> > > > > Please remove one of these at a time, it makes it much easier to review > > the patch. > > > > Should I resend this one as well? Yes.