All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org, guydavid@outlook.com
Subject: Re: [Qemu-devel] [PATCH] configure: add missing --disable-modules option
Date: Tue, 3 Nov 2015 08:24:47 +0800	[thread overview]
Message-ID: <20151103002447.GA6246@ad.usersys.redhat.com> (raw)
In-Reply-To: <1446473183-24250-1-git-send-email-stefanha@redhat.com>

On Mon, 11/02 14:06, Stefan Hajnoczi wrote:
> According to ./configure all options should have both --enable-foo and
> --disable-foo:
> 
>   # Always add --enable-foo and --disable-foo command line args.
>   # Distributions want to ensure that several features are compiled in, and it
>   # is impossible without a --enable-foo that exits if a feature is not found.

Actually the document is wrong about module support, the default is off:

> Optional features, enabled with --enable-FEATURE and
> disabled with --disable-FEATURE, default is enabled if available:

Maybe we should move it out of this section instead?

What about vnc-tls? It's described in the same place, but there is no option
for it.

Fam

  reply	other threads:[~2015-11-03  0:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-02 14:06 [Qemu-devel] [PATCH] configure: add missing --disable-modules option Stefan Hajnoczi
2015-11-03  0:24 ` Fam Zheng [this message]
2015-11-03 11:22   ` Stefan Hajnoczi
2015-11-03 11:31     ` Daniel P. Berrange
2015-11-03 11:56     ` Peter Maydell
2015-11-04  0:47       ` Fam Zheng
2015-11-06 11:31 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151103002447.GA6246@ad.usersys.redhat.com \
    --to=famz@redhat.com \
    --cc=guydavid@outlook.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.