From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: WEN Pingbo <pingbo.wen@linaro.org>
Cc: linux-input@vger.kernel.org, y2038@lists.linaro.org, arnd@arndb.de
Subject: Re: [PATCH 0/3] fix y2038 problem in input_event
Date: Mon, 2 Nov 2015 17:43:04 -0800 [thread overview]
Message-ID: <20151103014304.GA32018@dtor-ws> (raw)
In-Reply-To: <1446471339-25464-1-git-send-email-pingbo.wen@linaro.org>
Hi Wen,
On Mon, Nov 02, 2015 at 09:35:36PM +0800, WEN Pingbo wrote:
> Before this, I have discussed this problem with Arnd. And Arnd have
> an idea that by converting timeval to long / long in input_event, so that
> input_event structure size will be unchanged, and timeval structure will
> removed entirely. But we also need to avoid using CLOCK_REALTIME in
> userland, to keep the new input_event structure y2038 safe.
>
> The input_event will only support monotonic time in Arnd's idea. And
> we still need to add wall time support for old 32-bit binary.
>
> Those patches try to keep original input capacity, and resolve y2038
> problem in input_event radically.
>
> struct input_event is only used between kernel and userspace
> communication (except uinput). So that we can replace input_event
> with input_event64 in kernel entirely, and add a conversion in
> input_event_from/to_user() to keep compatible with old 32-bits binary.
>
> userland can switch to input_event64, which is y2038 safe, via ioctl.
If we are forcing userspace to change the protocol I'd rather explore
whether we need to transmit the timestamp in each and every event. I
would much rather drop it and instead introduce new event code for
timestamp (we already have MSC_TIMESTAMP for hardware-generated
timestamps, maybe we can introduce new ones for kernel-generated
timestamps).
Thanks.
--
Dmitry
next prev parent reply other threads:[~2015-11-03 1:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 13:35 [PATCH 0/3] fix y2038 problem in input_event WEN Pingbo
2015-11-02 13:35 ` [PATCH 1/3] evdev: convert input_event to input_event64 WEN Pingbo
2015-11-02 13:35 ` [PATCH 2/3] evdev: add new ioctl EVIOCSEVENT / EVIOCGEVENT WEN Pingbo
2015-11-02 13:35 ` [PATCH 3/3] uinput: convert input_event to input_event64 WEN Pingbo
2015-11-03 1:43 ` Dmitry Torokhov [this message]
2015-11-04 3:35 ` [PATCH 0/3] fix y2038 problem in input_event Pingbo Wen
2015-11-06 13:11 ` [Y2038] " Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103014304.GA32018@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-input@vger.kernel.org \
--cc=pingbo.wen@linaro.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.