All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: robert.dolca@intel.com
Cc: linux-wireless@vger.kernel.org
Subject: re: NFC: Add Intel Fields Peak NFC solution driver
Date: Tue, 3 Nov 2015 15:41:47 +0300	[thread overview]
Message-ID: <20151103124147.GA31752@mwanda> (raw)

Hello Robert Dolca,

This is a semi-automatic email about new static checker warnings.

The patch a06347c04c13: "NFC: Add Intel Fields Peak NFC solution 
driver" from Oct 22, 2015, leads to the following Smatch complaint:

drivers/nfc/fdp/i2c.c:216 fdp_nci_i2c_irq_thread_fn()
	 warn: variable dereferenced before check 'phy' (see line 213)

drivers/nfc/fdp/i2c.c
   212	
   213		client = phy->i2c_dev;
                         ^^^^^
Dereference.

   214		dev_dbg(&client->dev, "%s\n", __func__);
   215	
   216		if (!phy || irq != phy->i2c_dev->irq) {
                    ^^^^
Check.

   217			WARN_ON_ONCE(1);
   218			return IRQ_NONE;

regards,
dan carpenter

                 reply	other threads:[~2015-11-03 12:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151103124147.GA31752@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=robert.dolca@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.