From: Lee Jones <lee.jones@linaro.org>
To: Sebastien Jan <sjan@baylibre.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] mfd: arizona: Add DT binding for irq_gpio property
Date: Tue, 3 Nov 2015 13:29:52 +0000 [thread overview]
Message-ID: <20151103132952.GF3503@x1> (raw)
In-Reply-To: <1446549612-18221-1-git-send-email-sjan@baylibre.com>
On Tue, 03 Nov 2015, Sebastien Jan wrote:
> Signed-off-by: Sebastien Jan <sjan@baylibre.com>
> ---
> drivers/mfd/arizona-core.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 44cfdbb..23a0f93 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -814,6 +814,11 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
> count++;
> }
>
> + arizona->pdata.irq_gpio = of_get_named_gpio(arizona->dev->of_node,
> + "wlf,irq_gpio", 0);
> + if (arizona->pdata.irq_gpio < 0)
> + arizona->pdata.irq_gpio = 0;
This is wrong on a number of levels.
Firstly, all properties must be documented. Secondly, underscores
aren't allowed in DT. Thirdly, this is a generic binding -- no need
for the vendor prefix. And lastly, GPIO bindings already have a
format -- it should be simply 'irq-gpios'.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2015-11-03 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 11:20 [PATCH] mfd: arizona: Add DT binding for irq_gpio property Sebastien Jan
2015-11-03 13:29 ` Lee Jones [this message]
2015-11-03 13:47 ` Sebastien Jan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103132952.GF3503@x1 \
--to=lee.jones@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
--cc=sjan@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.