From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: qed: Add link support
Date: Tue, 03 Nov 2015 14:24:14 +0000 [thread overview]
Message-ID: <20151103142414.GA28591@mwanda> (raw)
Hello Yuval Mintz,
The patch cc875c2e4f34: "qed: Add link support" from Oct 26, 2015,
leads to the following static checker warning:
drivers/net/ethernet/qlogic/qed/qed_main.c:940 qed_set_link()
warn: bitwise AND condition is false here
drivers/net/ethernet/qlogic/qed/qed_main.c
925 link_params = qed_mcp_get_link_params(hwfn);
926 if (params->override_flags & QED_LINK_OVERRIDE_SPEED_AUTONEG)
927 link_params->speed.autoneg = params->autoneg;
928 if (params->override_flags & QED_LINK_OVERRIDE_SPEED_ADV_SPEEDS) {
929 link_params->speed.advertised_speeds = 0;
930 if ((params->adv_speeds & SUPPORTED_1000baseT_Half) ||
931 (params->adv_speeds & SUPPORTED_1000baseT_Full))
932 link_params->speed.advertised_speeds | 933 NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_1G;
934 if (params->adv_speeds & SUPPORTED_10000baseKR_Full)
935 link_params->speed.advertised_speeds | 936 NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_10G;
937 if (params->adv_speeds & SUPPORTED_40000baseLR4_Full)
938 link_params->speed.advertised_speeds | 939 NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_40G;
940 if (params->adv_speeds & 0)
^^^^^^^^^^^^^^^^^^^^^^
False.
941 link_params->speed.advertised_speeds | 942 NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_50G;
943 if (params->adv_speeds & 0)
^^^^^^^^^^^^^^^^^^^^^^
False.
944 link_params->speed.advertised_speeds | 945 NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_100G;
946 }
regards,
dan carpenter
reply other threads:[~2015-11-03 14:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103142414.GA28591@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.