From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 1/3] xen/x86: Correct {a, m}perf check in generic_identify() Date: Tue, 3 Nov 2015 09:31:49 -0500 Message-ID: <20151103143149.GA21174@l.oracle.com> References: <1446487185-10152-1-git-send-email-andrew.cooper3@citrix.com> <1446487185-10152-2-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1446487185-10152-2-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Jan Beulich , Xen-devel List-Id: xen-devel@lists.xenproject.org On Mon, Nov 02, 2015 at 05:59:43PM +0000, Andrew Cooper wrote: Reviewed-by: Konrad Rzeszutek Wilk > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > --- > xen/arch/x86/cpu/common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c > index 653b052..02f2504 100644 > --- a/xen/arch/x86/cpu/common.c > +++ b/xen/arch/x86/cpu/common.c > @@ -239,7 +239,7 @@ static void __cpuinit generic_identify(struct cpuinfo_x86 *c) > if ( cpu_has(c, X86_FEATURE_CLFLSH) ) > c->x86_clflush_size = ((ebx >> 8) & 0xff) * 8; > > - if ( (c->cpuid_level > CPUID_PM_LEAF) && > + if ( (c->cpuid_level >= CPUID_PM_LEAF) && > (cpuid_ecx(CPUID_PM_LEAF) & CPUID6_ECX_APERFMPERF_CAPABILITY) ) > set_bit(X86_FEATURE_APERFMPERF, c->x86_capability); > > -- > 2.1.4 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel