From: Damien Riegel <damien.riegel@savoirfairelinux.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck <wim@iguana.be>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
kernel@savoirfairelinux.com
Subject: Re: [PATCH 00/13] watchdog: factorize restart handler registration
Date: Tue, 3 Nov 2015 15:10:09 -0500 [thread overview]
Message-ID: <20151103201009.GA29029@localhost> (raw)
In-Reply-To: <5638F812.8010802@roeck-us.net>
On Tue, Nov 03, 2015 at 10:08:18AM -0800, Guenter Roeck wrote:
> On 11/03/2015 08:12 AM, Damien Riegel wrote:
> >Many drivers implements the exact same piece of code to register a
> >restart handler. It can be nice to factorize this in the watchdog core.
> >
> >The first patch adds an optional restart watchdog operation. If a driver
> >defines this operation, a restart handler is registered. By default, the
> >restart handler priority is set to 0, but a helper function
> >watchdog_set_restart_priority is provided to change it.
> >
> >The following patches bring this change to the current watchdog drivers
> >that use watchdog_core.
> >
> >This change has been compile-tested on da9063, imx2, lpc18xx, imgpdc.
> >It has been tested with (not mainlined yet) ts-4800's watchdog driver.
> >
> >Damien Riegel (13):
> > watchdog: core: add restart handler support
> > watchdog: bcm47xx_wdt: use core restart handler
> > watchdog: da9063_wdt: use core restart handler
> > watchdog: digicolor_wdt: use core restart handler
> > watchdog: imgpdc_wdt: use core restart handler
> > watchdog: imx2_wdt: use core restart handler
> > watchdog: lpc18xx_wdt: use core restart handler
> > watchdog: meson_wdt: use core restart handler
> > watchdog: moxart_wdt: use core restart handler
> > watchdog: mtk_wdt: use core restart handler
> > watchdog: qcom-wdt: use core restart handler
> > watchdog: s3c2410_wdt: use core restart handler
> > watchdog: sunxi_wdt: use core restart handler
> >
>
> Damien,
>
> "v2" in the subject line as well as a change log would have been appreciated.
> You are making it (hopefully not intentionally) difficult for maintainers
> to separate v1 from v2. You might want to keep in mind that maintainers are
> in general quite busy and might thus be a bit annoyed about such additional
> (and unnecessary) work.
Sorry for the inconvenience, I assumed it was correct to send the
patchset as a v1 since the previous one was a RFC. Do you want me to
resend this serie as a v2 with a changelog ?
Damien
next prev parent reply other threads:[~2015-11-03 20:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 16:12 [PATCH 00/13] watchdog: factorize restart handler registration Damien Riegel
2015-11-03 16:12 ` [PATCH 01/13] watchdog: core: add restart handler support Damien Riegel
2015-11-03 16:12 ` [PATCH 02/13] watchdog: bcm47xx_wdt: use core restart handler Damien Riegel
2015-11-03 16:12 ` [PATCH 03/13] watchdog: da9063_wdt: " Damien Riegel
2015-11-03 16:12 ` [PATCH 04/13] watchdog: digicolor_wdt: " Damien Riegel
2015-11-03 16:12 ` [PATCH 05/13] watchdog: imgpdc_wdt: " Damien Riegel
2015-11-03 16:12 ` [PATCH 06/13] watchdog: imx2_wdt: " Damien Riegel
2015-11-03 16:12 ` [PATCH 07/13] watchdog: lpc18xx_wdt: " Damien Riegel
2015-11-03 16:12 ` [PATCH 08/13] watchdog: meson_wdt: " Damien Riegel
2015-11-03 16:12 ` [PATCH 09/13] watchdog: moxart_wdt: " Damien Riegel
2015-11-03 16:12 ` [PATCH 10/13] watchdog: mtk_wdt: " Damien Riegel
2015-11-03 16:12 ` [PATCH 11/13] watchdog: qcom-wdt: " Damien Riegel
2015-11-03 16:12 ` [PATCH 12/13] watchdog: s3c2410_wdt: " Damien Riegel
2015-11-03 16:12 ` [PATCH 13/13] watchdog: sunxi_wdt: " Damien Riegel
2015-11-03 18:08 ` [PATCH 00/13] watchdog: factorize restart handler registration Guenter Roeck
2015-11-03 18:19 ` Vivien Didelot
2015-11-03 20:10 ` Damien Riegel [this message]
2015-11-03 21:10 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103201009.GA29029@localhost \
--to=damien.riegel@savoirfairelinux.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=vivien.didelot@savoirfairelinux.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.