From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Renaud Barbier <renaud.barbier@ge.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Subject: Re: nand_flash_detect_onfi error
Date: Tue, 3 Nov 2015 21:54:24 +0100 [thread overview]
Message-ID: <20151103215424.40169dd4@bbrezillon> (raw)
In-Reply-To: <20151103204511.GI7274@google.com>
On Tue, 3 Nov 2015 12:45:11 -0800
Brian Norris <computersforpeace@gmail.com> wrote:
> On Tue, Nov 03, 2015 at 09:25:46PM +0100, Boris Brezillon wrote:
> > On Tue, 3 Nov 2015 13:56:16 -0300
> > Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> wrote:
> > > On 3 November 2015 at 13:27, Renaud Barbier <renaud.barbier@ge.com> wrote:
> > > > chip->cmdfunc(mtd, NAND_CMD_PARAM, 0, -1);
> > > > for (i = 0; i < 3; i++) {
> > > > for (j = 0; j < sizeof(*p); j++)
> > > > ((uint8_t *)p)[j] = chip->read_byte(mtd);
> > > > if (onfi_crc16(ONFI_CRC_BASE, (uint8_t *)p, 254) ==
> > > > le16_to_cpu(p->crc)) {
> > > > break;
> > > > }
> > > > }
> > > >
> ...
> > BTW, I wonder why ->read_byte() is used instead of ->read_buf() here.
>
> commit bd9c6e99b58255b9de1982711ac9487c9a2f18be
> Author: Brian Norris <computersforpeace@gmail.com>
> Date: Fri Nov 29 22:04:28 2013 -0800
>
> mtd: nand: don't use read_buf for 8-bit ONFI transfers
Makes sense. Thanks for pointing this out.
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-11-03 20:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 16:27 nand_flash_detect_onfi error Renaud Barbier
2015-11-03 16:56 ` Ezequiel Garcia
2015-11-03 20:25 ` Boris Brezillon
2015-11-03 20:45 ` Brian Norris
2015-11-03 20:54 ` Boris Brezillon [this message]
2015-11-03 20:57 ` Brian Norris
2015-11-03 20:59 ` Ezequiel Garcia
2015-11-03 21:18 ` Boris Brezillon
2015-11-04 16:24 ` Renaud Barbier
2015-11-04 17:54 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103215424.40169dd4@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-mtd@lists.infradead.org \
--cc=renaud.barbier@ge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.