From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Date: Tue, 03 Nov 2015 22:09:20 +0000 Subject: Re: Mobility Radeon HD 4530/4570/545v: flicker in 1920x1080 Message-Id: <20151103220919.GA4824@amd> List-Id: References: <20151031201344.GA30459@amd> <563522C5.1000206@amd.com> <20151031212259.GA6253@amd> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alex Deucher Cc: "Deucher, Alexander" , "linux-fbdev@vger.kernel.org" , Christian =?iso-8859-1?Q?K=F6nig?= , Maling list - DRI developers , kernel list Hi! > >> >4.3-rc7 kernel, graphics works reasonably well in 1600x1200 mode. But > >> >my monitor is native 1920x1080, so that mode looks pretty ugly on > >> >screen. If I go to 1920x1080, I see colored horizontal lines (often > >> >black) as soon as there's graphics activity. > >> > > >> >pavel@half:~$ xrandr > >> >Screen 0: minimum 320 x 200, current 1920 x 1080, maximum 8192 x 8192 > >> >VGA-0 connected 1920x1080+0+0 (normal left inverted right x axis y > >> >axis) 478mm x 268mm > >> > 1920x1080 60.00*+ > >> > 1600x1200 60.00 > >> > 1680x1050 59.95 > >> > 1280x1024 75.02 60.02 > >> > 1440x900 59.89 > >> > 1024x768 75.08 60.00 > >> > 800x600 75.00 60.32 > >> > 640x480 75.00 60.00 > >> > 720x400 70.08 > >> > pavel@half:~$ xrandr --output VGA-0 --mode 1600x1200 > >> > pavel@half:~$ xrandr --output VGA-0 --mode 1920x1080 > >> > pavel@half:~$ xrandr --output VGA-0 --mode 1600x1200 > >> > > >> >Any ideas? > >> > >> Alex probably knows more about this, but it sounds like problems with > >> switching the memory clocks on 3D load. > > > >> Try to disable power management completely with radeon.dpm=0 on the kernel > >> command line or nailing the hardware at a specific power level using > >> sysfs. > > > > I tried that, but it still flickers. > > It's probably pll stability. There seem to be a number of regressions > since the pll code was rewritten to support matching the hdmi clocks > more closely. Does this patch help? > > diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c > b/drivers/gpu/drm/radeon/atombios_crtc.c > index dac78ad..b86f06a 100644 > --- a/drivers/gpu/drm/radeon/atombios_crtc.c > +++ b/drivers/gpu/drm/radeon/atombios_crtc.c > @@ -569,6 +569,8 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc, > radeon_crtc->pll_flags = 0; > > if (ASIC_IS_AVIVO(rdev)) { > + radeon_crtc->pll_flags |= RADEON_PLL_PREFER_MINM_OVER_MAXP; > + > if ((rdev->family = CHIP_RS600) || > (rdev->family = CHIP_RS690) || > (rdev->family = CHIP_RS740)) > Help.. maybe... it is tricky to tell. It definitely does _not_ fix the issue completely. > Unfortunately, it can't be applied as is because we had a similar > patch which was reverted because it regressed a bunch of other > systems. The actual pll limits probably need to be tweaked. Any ideas how to tweak the pll limits? Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: Mobility Radeon HD 4530/4570/545v: flicker in 1920x1080 Date: Tue, 3 Nov 2015 23:09:20 +0100 Message-ID: <20151103220919.GA4824@amd> References: <20151031201344.GA30459@amd> <563522C5.1000206@amd.com> <20151031212259.GA6253@amd> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from atrey.karlin.mff.cuni.cz (atrey.karlin.mff.cuni.cz [195.113.26.193]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F6B86E832 for ; Tue, 3 Nov 2015 14:09:22 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher Cc: "Deucher, Alexander" , "linux-fbdev@vger.kernel.org" , Christian =?iso-8859-1?Q?K=F6nig?= , Maling list - DRI developers , kernel list List-Id: dri-devel@lists.freedesktop.org SGkhCgo+ID4+ID40LjMtcmM3IGtlcm5lbCwgZ3JhcGhpY3Mgd29ya3MgcmVhc29uYWJseSB3ZWxs IGluIDE2MDB4MTIwMCBtb2RlLiBCdXQKPiA+PiA+bXkgbW9uaXRvciBpcyBuYXRpdmUgMTkyMHgx MDgwLCBzbyB0aGF0IG1vZGUgbG9va3MgcHJldHR5IHVnbHkgb24KPiA+PiA+c2NyZWVuLiBJZiBJ IGdvIHRvIDE5MjB4MTA4MCwgSSBzZWUgY29sb3JlZCBob3Jpem9udGFsIGxpbmVzIChvZnRlbgo+ ID4+ID5ibGFjaykgYXMgc29vbiBhcyB0aGVyZSdzIGdyYXBoaWNzIGFjdGl2aXR5Lgo+ID4+ID4K PiA+PiA+cGF2ZWxAaGFsZjp+JCB4cmFuZHIKPiA+PiA+U2NyZWVuIDA6IG1pbmltdW0gMzIwIHgg MjAwLCBjdXJyZW50IDE5MjAgeCAxMDgwLCBtYXhpbXVtIDgxOTIgeCA4MTkyCj4gPj4gPlZHQS0w IGNvbm5lY3RlZCAxOTIweDEwODArMCswIChub3JtYWwgbGVmdCBpbnZlcnRlZCByaWdodCB4IGF4 aXMgeQo+ID4+ID5heGlzKSA0NzhtbSB4IDI2OG1tCj4gPj4gPiAgICAxOTIweDEwODAgICAgIDYw LjAwKisKPiA+PiA+ICAgICAgIDE2MDB4MTIwMCAgICAgNjAuMDAKPiA+PiA+ICAgICAgICAgIDE2 ODB4MTA1MCAgICAgNTkuOTUKPiA+PiA+ICAgICAgICAgMTI4MHgxMDI0ICAgICA3NS4wMiAgICA2 MC4wMgo+ID4+ID4gICAgICAgICAgICAxNDQweDkwMCAgICAgIDU5Ljg5Cj4gPj4gPiAgICAgICAg ICAgICAgIDEwMjR4NzY4ICAgICAgNzUuMDggICAgNjAuMDAKPiA+PiA+ICAgICAgICAgICAgICAg ICAgODAweDYwMCAgICAgICA3NS4wMCAgICA2MC4zMgo+ID4+ID4gICAgICAgICAgICAgICAgICAg ICA2NDB4NDgwICAgICAgIDc1LjAwICAgIDYwLjAwCj4gPj4gPiAgICAgICAgICAgICAgICAgICAg ICAgIDcyMHg0MDAgICAgICAgNzAuMDgKPiA+PiA+ICBwYXZlbEBoYWxmOn4kIHhyYW5kciAtLW91 dHB1dCBWR0EtMCAtLW1vZGUgMTYwMHgxMjAwCj4gPj4gPiAgcGF2ZWxAaGFsZjp+JCB4cmFuZHIg LS1vdXRwdXQgVkdBLTAgLS1tb2RlIDE5MjB4MTA4MAo+ID4+ID4gIHBhdmVsQGhhbGY6fiQgeHJh bmRyIC0tb3V0cHV0IFZHQS0wIC0tbW9kZSAxNjAweDEyMDAKPiA+PiA+Cgo+ID4+ID5BbnkgaWRl YXM/Cj4gPj4KPiA+PiBBbGV4IHByb2JhYmx5IGtub3dzIG1vcmUgYWJvdXQgdGhpcywgYnV0IGl0 IHNvdW5kcyBsaWtlIHByb2JsZW1zIHdpdGgKPiA+PiBzd2l0Y2hpbmcgdGhlIG1lbW9yeSBjbG9j a3Mgb24gM0QgbG9hZC4KPiA+Cj4gPj4gVHJ5IHRvIGRpc2FibGUgcG93ZXIgbWFuYWdlbWVudCBj b21wbGV0ZWx5IHdpdGggcmFkZW9uLmRwbT0wIG9uIHRoZSBrZXJuZWwKPiA+PiBjb21tYW5kIGxp bmUgb3IgbmFpbGluZyB0aGUgaGFyZHdhcmUgYXQgYSBzcGVjaWZpYyBwb3dlciBsZXZlbCB1c2lu Zwo+ID4+IHN5c2ZzLgo+ID4KPiA+IEkgdHJpZWQgdGhhdCwgYnV0IGl0IHN0aWxsIGZsaWNrZXJz Lgo+IAo+IEl0J3MgcHJvYmFibHkgcGxsIHN0YWJpbGl0eS4gIFRoZXJlIHNlZW0gdG8gYmUgYSBu dW1iZXIgb2YgcmVncmVzc2lvbnMKPiBzaW5jZSB0aGUgcGxsIGNvZGUgd2FzIHJld3JpdHRlbiB0 byBzdXBwb3J0IG1hdGNoaW5nIHRoZSBoZG1pIGNsb2Nrcwo+IG1vcmUgY2xvc2VseS4gIERvZXMg dGhpcyBwYXRjaCBoZWxwPwo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcmFkZW9u L2F0b21iaW9zX2NydGMuYwo+IGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9hdG9tYmlvc19jcnRj LmMKPiBpbmRleCBkYWM3OGFkLi5iODZmMDZhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9yYWRlb24vYXRvbWJpb3NfY3J0Yy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9h dG9tYmlvc19jcnRjLmMKPiBAQCAtNTY5LDYgKzU2OSw4IEBAIHN0YXRpYyB1MzIgYXRvbWJpb3Nf YWRqdXN0X3BsbChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gICAgICAgICByYWRlb25fY3J0Yy0+ cGxsX2ZsYWdzID0gMDsKPiAKPiAgICAgICAgIGlmIChBU0lDX0lTX0FWSVZPKHJkZXYpKSB7Cj4g KyAgICAgICAgICAgICAgIHJhZGVvbl9jcnRjLT5wbGxfZmxhZ3MgfD0gUkFERU9OX1BMTF9QUkVG RVJfTUlOTV9PVkVSX01BWFA7Cj4gKwo+ICAgICAgICAgICAgICAgICBpZiAoKHJkZXYtPmZhbWls eSA9PSBDSElQX1JTNjAwKSB8fAo+ICAgICAgICAgICAgICAgICAgICAgKHJkZXYtPmZhbWlseSA9 PSBDSElQX1JTNjkwKSB8fAo+ICAgICAgICAgICAgICAgICAgICAgKHJkZXYtPmZhbWlseSA9PSBD SElQX1JTNzQwKSkKPgoKSGVscC4uIG1heWJlLi4uIGl0IGlzIHRyaWNreSB0byB0ZWxsLiBJdCBk ZWZpbml0ZWx5IGRvZXMgX25vdF8gZml4IHRoZQppc3N1ZSBjb21wbGV0ZWx5LgoKPiBVbmZvcnR1 bmF0ZWx5LCBpdCBjYW4ndCBiZSBhcHBsaWVkIGFzIGlzIGJlY2F1c2Ugd2UgaGFkIGEgc2ltaWxh cgo+IHBhdGNoIHdoaWNoIHdhcyByZXZlcnRlZCBiZWNhdXNlIGl0IHJlZ3Jlc3NlZCBhIGJ1bmNo IG9mIG90aGVyCj4gc3lzdGVtcy4gIFRoZSBhY3R1YWwgcGxsIGxpbWl0cyBwcm9iYWJseSBuZWVk IHRvIGJlIHR3ZWFrZWQuCgpBbnkgaWRlYXMgaG93IHRvIHR3ZWFrIHRoZSBwbGwgbGltaXRzPwoK VGhhbmtzLAoJCQkJCQkJCVBhdmVsCi0tIAooZW5nbGlzaCkgaHR0cDovL3d3dy5saXZlam91cm5h bC5jb20vfnBhdmVsbWFjaGVrCihjZXNreSwgcGljdHVyZXMpIGh0dHA6Ly9hdHJleS5rYXJsaW4u bWZmLmN1bmkuY3ovfnBhdmVsL3BpY3R1cmUvaG9yc2VzL2Jsb2cuaHRtbApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965072AbbKCWJZ (ORCPT ); Tue, 3 Nov 2015 17:09:25 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:54453 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755150AbbKCWJX (ORCPT ); Tue, 3 Nov 2015 17:09:23 -0500 Date: Tue, 3 Nov 2015 23:09:20 +0100 From: Pavel Machek To: Alex Deucher Cc: Christian =?iso-8859-1?Q?K=F6nig?= , "Deucher, Alexander" , "linux-fbdev@vger.kernel.org" , kernel list , Maling list - DRI developers Subject: Re: Mobility Radeon HD 4530/4570/545v: flicker in 1920x1080 Message-ID: <20151103220919.GA4824@amd> References: <20151031201344.GA30459@amd> <563522C5.1000206@amd.com> <20151031212259.GA6253@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > >> >4.3-rc7 kernel, graphics works reasonably well in 1600x1200 mode. But > >> >my monitor is native 1920x1080, so that mode looks pretty ugly on > >> >screen. If I go to 1920x1080, I see colored horizontal lines (often > >> >black) as soon as there's graphics activity. > >> > > >> >pavel@half:~$ xrandr > >> >Screen 0: minimum 320 x 200, current 1920 x 1080, maximum 8192 x 8192 > >> >VGA-0 connected 1920x1080+0+0 (normal left inverted right x axis y > >> >axis) 478mm x 268mm > >> > 1920x1080 60.00*+ > >> > 1600x1200 60.00 > >> > 1680x1050 59.95 > >> > 1280x1024 75.02 60.02 > >> > 1440x900 59.89 > >> > 1024x768 75.08 60.00 > >> > 800x600 75.00 60.32 > >> > 640x480 75.00 60.00 > >> > 720x400 70.08 > >> > pavel@half:~$ xrandr --output VGA-0 --mode 1600x1200 > >> > pavel@half:~$ xrandr --output VGA-0 --mode 1920x1080 > >> > pavel@half:~$ xrandr --output VGA-0 --mode 1600x1200 > >> > > >> >Any ideas? > >> > >> Alex probably knows more about this, but it sounds like problems with > >> switching the memory clocks on 3D load. > > > >> Try to disable power management completely with radeon.dpm=0 on the kernel > >> command line or nailing the hardware at a specific power level using > >> sysfs. > > > > I tried that, but it still flickers. > > It's probably pll stability. There seem to be a number of regressions > since the pll code was rewritten to support matching the hdmi clocks > more closely. Does this patch help? > > diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c > b/drivers/gpu/drm/radeon/atombios_crtc.c > index dac78ad..b86f06a 100644 > --- a/drivers/gpu/drm/radeon/atombios_crtc.c > +++ b/drivers/gpu/drm/radeon/atombios_crtc.c > @@ -569,6 +569,8 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc, > radeon_crtc->pll_flags = 0; > > if (ASIC_IS_AVIVO(rdev)) { > + radeon_crtc->pll_flags |= RADEON_PLL_PREFER_MINM_OVER_MAXP; > + > if ((rdev->family == CHIP_RS600) || > (rdev->family == CHIP_RS690) || > (rdev->family == CHIP_RS740)) > Help.. maybe... it is tricky to tell. It definitely does _not_ fix the issue completely. > Unfortunately, it can't be applied as is because we had a similar > patch which was reverted because it regressed a bunch of other > systems. The actual pll limits probably need to be tweaked. Any ideas how to tweak the pll limits? Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html