From: Brian Norris <computersforpeace@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Axel Lin <axel.lin@ingics.com>,
Thierry Reding <thierry.reding@gmail.com>,
Gregory Fong <gregory.0xf0@gmail.com>,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH] pwm: brcmstb: Don't set can_sleep flag
Date: Tue, 3 Nov 2015 17:08:03 -0800 [thread overview]
Message-ID: <20151104010803.GK7274@google.com> (raw)
In-Reply-To: <56395630.1030405@gmail.com>
On Tue, Nov 03, 2015 at 04:49:52PM -0800, Florian Fainelli wrote:
> Now, I do agree that the terminology is a little confusing here. If you
> look at the GPIO API there are gpio_*_cansleep() accessors, which in
> their case, convey the correct meaning: the operation can/might sleep.
Perhaps I'm misreading, but that actually sounds exactly the same as the
pwm_can_sleep() API. It sounds OK from a consumer/API perspective, but I
was just commenting on the perspective of the driver writer.
Maybe it's not worth much change, then, if several subsystems have
similar naming.
Brian
prev parent reply other threads:[~2015-11-04 1:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 10:08 [PATCH] pwm: brcmstb: Don't set can_sleep flag Axel Lin
2015-11-04 0:18 ` Florian Fainelli
2015-11-04 0:31 ` Brian Norris
2015-11-04 0:49 ` Florian Fainelli
2015-11-04 1:08 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151104010803.GK7274@google.com \
--to=computersforpeace@gmail.com \
--cc=axel.lin@ingics.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.