From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 4/7] IB/srp: Fix a potential queue overflow in an error path Date: Tue, 3 Nov 2015 20:03:22 -0800 Message-ID: <20151104040322.GA22142@infradead.org> References: <562FF404.7000504@sandisk.com> <562FF484.6030400@sandisk.com> <5638F08D.9070206@dev.mellanox.co.il> <56390557.204@sandisk.com> <56391181.8040207@dev.mellanox.co.il> <56391290.2080708@sandisk.com> <5639157C.2060107@dev.mellanox.co.il> <56391E33.5050300@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <56391E33.5050300-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bart Van Assche Cc: Sagi Grimberg , Doug Ledford , Sebastian Parschauer , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Tue, Nov 03, 2015 at 12:50:59PM -0800, Bart Van Assche wrote: > Such a check wouldn't be that simple because the only way to perform such a > check is either by doubling the number of ib_map_mr_sg() calls or by > performing additional memory allocations. The other option woud be to disallow gappy SG lists unless supported by the hardware with a single MR similar to iSER. While this would leave the SRP protocol support for multiple SG entries per command unused it would significantly simplify the driver. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html