From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030359AbbKDOrk (ORCPT ); Wed, 4 Nov 2015 09:47:40 -0500 Received: from m50-132.163.com ([123.125.50.132]:52103 "EHLO m50-132.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030246AbbKDOri (ORCPT ); Wed, 4 Nov 2015 09:47:38 -0500 Date: Wed, 4 Nov 2015 22:45:42 +0800 From: Geliang Tang To: Arnd Bergmann Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] efirtc: add efi_enabled check in efi_rtc_init Message-ID: <20151104144542.GA3613@bogon> References: <4a37e163f338e9f16c4bae9c819b35afaacbf585.1446475492.git.geliangtang@163.com> <280fb52bda85af452e129fa5633598954801871c.1446475492.git.geliangtang@163.com> <6366386.xsGhxxeFtE@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6366386.xsGhxxeFtE@wuerfel> User-Agent: Mutt/1.5.24 (2015-08-30) X-CM-TRANSID: DNGowEDZjE8VGjpW+zn+Aw--.14428S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7XFyUXFyrXr1xXr45WFWxJFb_yoWxuwc_uF 4xZFZ7Cr1vgFZ7tF4Syr4fu345K3s8X3s7AFs0q3W3A3WfZF1rJrWDurn5Ww4YkFs7JF9I vw45AFyfZa1SkjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8go7tUUUUU== X-Originating-IP: [116.77.134.248] X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/xtbByhOomVO+fqOREQABsZ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 02, 2015 at 04:37:51PM +0100, Arnd Bergmann wrote: > On Monday 02 November 2015 22:49:01 Geliang Tang wrote: > > diff --git a/drivers/char/efirtc.c b/drivers/char/efirtc.c > > index 5323d8c..80058bd 100644 > > --- a/drivers/char/efirtc.c > > +++ b/drivers/char/efirtc.c > > @@ -378,6 +378,9 @@ efi_rtc_init(void) > > int ret; > > struct proc_dir_entry *dir; > > > > + if (!efi_enabled(EFI_RUNTIME_SERVICES)) > > + return 0; > > > > Are there any Itanium machines that don't enable runtime services? > This seems a little redundant otherwise. > > Are you trying to run the ancient driver on non-Itanium systems? Yes. I did run this driver on a EFI-based X86_64 machine. Geliang Tang