From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jiaxing Wang <hello.wjx@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] tracing: Make tracing work when debugfs is not compiled or initialized.
Date: Wed, 4 Nov 2015 10:54:42 -0800 [thread overview]
Message-ID: <20151104185442.GA19152@kroah.com> (raw)
In-Reply-To: <20151104100339.583e1bc9@gandalf.local.home>
On Wed, Nov 04, 2015 at 10:03:39AM -0500, Steven Rostedt wrote:
> On Wed, 4 Nov 2015 09:11:18 +0800
> Jiaxing Wang <hello.wjx@gmail.com> wrote:
>
> > Currently tracing_init_dentry() returns -ENODEV when debugfs is not
> > initialized, which causes tracefs not populated with tracing files and
> > directories, so we will get an empty directory even after we manually
> > mount tracefs.
> >
> > We can make tracing_init_dentry() return NULL as long as tracefs
> > is initialized and get a populated tracefs.
> >
> > We also need to make global_trace.dir not NULL in order to pass the checks
> > in tracing_get_dentry() and add_tracer_options().
> >
> > Also added stub debugfs_create_automount() for when debugfs is not
> > configured in.
The debugfs change should be split out into a separate patch, which I'll
be glad to take through my tree, it isn't dependant on the tracing
code at all.
thanks,
greg k-h
next prev parent reply other threads:[~2015-11-04 18:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-18 11:58 [PATCH 0/3] Some tracing fixes Jiaxing Wang
2015-10-18 11:58 ` [PATCH 1/3] tracing: Update instance_rmdir() to use tracefs_remove_recursive Jiaxing Wang
2015-10-18 11:58 ` [PATCH 2/3] tracing: Make tracing work when debugfs is not compiled or initialized Jiaxing Wang
2015-10-18 14:32 ` kbuild test robot
2015-10-19 1:54 ` Jiaxing Wang
2015-11-02 14:16 ` Steven Rostedt
2015-11-04 1:11 ` [PATCH RESEND] " Jiaxing Wang
2015-11-04 15:03 ` Steven Rostedt
2015-11-04 18:54 ` Greg Kroah-Hartman [this message]
2015-11-04 20:32 ` Steven Rostedt
2015-11-05 5:23 ` Jiaxing Wang
2015-11-05 15:54 ` Steven Rostedt
2015-11-06 8:02 ` Jiaxing Wang
2015-11-06 8:04 ` [PATCH] tracing: Make tracing work when debugfs is not configured in Jiaxing Wang
2015-10-18 11:58 ` [PATCH 3/3] tracing: Apply tracer specific options from kernel command line Jiaxing Wang
2015-11-02 19:04 ` Steven Rostedt
2015-11-04 1:14 ` [PATCH v2] " Jiaxing Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151104185442.GA19152@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hello.wjx@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.