Re: [Outreachy kernel] [PATCH] Staging: lustre: tracefile: Remove wrapper function

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Nov 02, 2015 at 11:42:37PM +0530, Shivani Bhardwaj wrote:
> Remove the function cfs_tage_from_list() and replace all its calls with
> the function it wrapped.
> 
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
>  drivers/staging/lustre/lustre/libcfs/tracefile.c | 18 ++++++++----------
>  1 file changed, 8 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/libcfs/tracefile.c b/drivers/staging/lustre/lustre/libcfs/tracefile.c
> index 973c7c2..907214a 100644
> --- a/drivers/staging/lustre/lustre/libcfs/tracefile.c
> +++ b/drivers/staging/lustre/lustre/libcfs/tracefile.c
> @@ -59,12 +59,6 @@ static atomic_t cfs_tage_allocated = ATOMIC_INIT(0);
>  static void put_pages_on_tcd_daemon_list(struct page_collection *pc,
>  					 struct cfs_trace_cpu_data *tcd);
>  
> -static inline struct cfs_trace_page *
> -cfs_tage_from_list(struct list_head *list)
> -{
> -	return list_entry(list, struct cfs_trace_page, linkage);
> -}

No, this is a "good" function to keep around, it makes it easier to
understand what is going on, and easier to remember how to call it
instead of having to look up the list_entry() logic each time.

So please keep this one.

thanks,

greg k-h