Re: [Outreachy kernel] [PATCH 3/3] Staging: lustre: module: Replace function calls

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Nov 03, 2015 at 12:19:36AM +0530, Shivani Bhardwaj wrote:
> Replace the calls of function cfs_trace_free_string_buffer() with
> kfree() as the former function is not required.
> 
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
>  drivers/staging/lustre/lustre/libcfs/module.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/libcfs/module.c b/drivers/staging/lustre/lustre/libcfs/module.c
> index 50e8fd2..516a9e7 100644
> --- a/drivers/staging/lustre/lustre/libcfs/module.c
> +++ b/drivers/staging/lustre/lustre/libcfs/module.c
> @@ -392,7 +392,7 @@ static int __proc_dobitmasks(void *data, int write,
>  	} else {
>  		rc = cfs_trace_copyin_string(tmpstr, tmpstrlen, buffer, nob);
>  		if (rc < 0) {
> -			cfs_trace_free_string_buffer(tmpstr, tmpstrlen);
> +			kfree(tmpstr);
>  			return rc;
>  		}
>  
> @@ -402,7 +402,7 @@ static int __proc_dobitmasks(void *data, int write,
>  			*mask |= D_EMERG;
>  	}
>  
> -	cfs_trace_free_string_buffer(tmpstr, tmpstrlen);
> +	kfree(tmpstr);
>  	return rc;
>  }
>  

Don't you need this to be earlier in the series?  You just deleted the
function from the kernel in the first patch :(

Never break the build for any patch in a series.  Please reorder and
resend.

thanks,

greg k-h