Re: [Outreachy kernel] [PATCH v3] staging: rdma: amso1100: Drop wrapper function

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Nov 02, 2015 at 05:37:28PM +0530, Amitoj Kaur Chawla wrote:
> This patch removes the c2_print_macaddr() wrapper function which calls
> the pr_debug standard kernel function only.
> 
> c2_print_macaddr() has been replaced by directly calling pr_debug().
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> Changes in v2:
>         -Corrected indentation
>         -Removed comment added in previous version
> Changes in v3:
>         -Corrected indentation
> 
>  drivers/staging/rdma/amso1100/c2.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/rdma/amso1100/c2.c b/drivers/staging/rdma/amso1100/c2.c
> index 7f1e794..6688349 100644
> --- a/drivers/staging/rdma/amso1100/c2.c
> +++ b/drivers/staging/rdma/amso1100/c2.c
> @@ -87,11 +87,6 @@ static struct pci_device_id c2_pci_table[] = {
>  
>  MODULE_DEVICE_TABLE(pci, c2_pci_table);
>  
> -static void c2_print_macaddr(struct net_device *netdev)
> -{
> -	pr_debug("%s: MAC %pM, IRQ %u\n", netdev->name, netdev->dev_addr, netdev->irq);
> -}
> -
>  static void c2_set_rxbufsize(struct c2_port *c2_port)
>  {
>  	struct net_device *netdev = c2_port->netdev;
> @@ -908,7 +903,8 @@ static struct net_device *c2_devinit(struct c2_dev *c2dev,
>  	/* Validate the MAC address */
>  	if (!is_valid_ether_addr(netdev->dev_addr)) {
>  		pr_debug("Invalid MAC Address\n");
> -		c2_print_macaddr(netdev);
> +		pr_debug("%s: MAC %pM, IRQ %u\n", netdev->name,
> +				netdev->dev_addr, netdev->irq);
>  		free_netdev(netdev);
>  		return NULL;
>  	}
> @@ -1142,7 +1138,8 @@ static int c2_probe(struct pci_dev *pcidev, const struct pci_device_id *ent)
>  	}
>  
>  	/* Print out the MAC address */
> -	c2_print_macaddr(netdev);
> +	pr_debug("%s: MAC %pM, IRQ %u\n", netdev->name, netdev->dev_addr, 
> +			netdev->irq);

You added trailing whitespace, which is not allowed :(