Re: [Outreachy kernel] [PATCH] staging: rts5208: Remove wrapper function

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Oct 29, 2015 at 02:20:03PM +0530, Amitoj Kaur Chawla wrote:
> Drop wrapper function that can be replaced by a single line of code.
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
>  drivers/staging/rts5208/rtsx_chip.c | 9 ++-------
>  drivers/staging/rts5208/rtsx_chip.h | 1 -
>  drivers/staging/rts5208/rtsx_scsi.c | 2 +-
>  3 files changed, 3 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c
> index c0ce659..ca9f021 100644
> --- a/drivers/staging/rts5208/rtsx_chip.c
> +++ b/drivers/staging/rts5208/rtsx_chip.c
> @@ -109,11 +109,6 @@ void rtsx_enable_bus_int(struct rtsx_chip *chip)
>  	dev_dbg(rtsx_dev(chip), "RTSX_BIER: 0x%08x\n", reg);
>  }
>  
> -void rtsx_disable_bus_int(struct rtsx_chip *chip)
> -{
> -	rtsx_writel(chip, RTSX_BIER, 0);
> -}

This is a "useful" function in that it does a specific thing, and makes
the code easier to read, so please don't remove it.

thanks,

greg k-h