Re: [Outreachy kernel] [PATCH 1/4] staging: rtl8712: rtl871x_sta_mgt: Remove wrapper function

[Greg KH <gregkh@linuxfoundation.org>]

On Sat, Oct 31, 2015 at 08:16:27PM +0530, Amitoj Kaur Chawla wrote:
> Remove wrapper function that can be replaced by a single line of code.
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
>  drivers/staging/rtl8712/rtl871x_sta_mgt.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl871x_sta_mgt.c b/drivers/staging/rtl8712/rtl871x_sta_mgt.c
> index 6ae8cdc..a379b84 100644
> --- a/drivers/staging/rtl8712/rtl871x_sta_mgt.c
> +++ b/drivers/staging/rtl8712/rtl871x_sta_mgt.c
> @@ -89,16 +89,11 @@ static void mfree_all_stainfo(struct sta_priv *pstapriv)
>  	spin_unlock_irqrestore(&pstapriv->sta_hash_lock, irqL);
>  }
>  
> -
> -static void mfree_sta_priv_lock(struct	sta_priv *pstapriv)
> -{
> -	 mfree_all_stainfo(pstapriv); /* be done before free sta_hash_lock */
> -}
> -
>  u32 _r8712_free_sta_priv(struct sta_priv *pstapriv)
>  {
>  	if (pstapriv) {
> -		mfree_sta_priv_lock(pstapriv);
> +		/* be done before free sta_hash_lock */
> +		mfree_all_stainfo(pstapriv); 

You add trailing whitespace :(

Always check your patches with checkpatch before sending them out.

thanks,

greg k-h