From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Date: Wed, 04 Nov 2015 22:10:00 +0000 Subject: Re: Mobility Radeon HD 4530/4570/545v: flicker in 1920x1080 Message-Id: <20151104221000.GA3608@amd> List-Id: References: <20151031201344.GA30459@amd> <563522C5.1000206@amd.com> <20151031212259.GA6253@amd> <20151103220919.GA4824@amd> <20151103230329.GA4167@amd> <5639B580.1050409@vodafone.de> In-Reply-To: <5639B580.1050409@vodafone.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: "linux-fbdev@vger.kernel.org" , kernel list , Maling list - DRI developers , "Deucher, Alexander" , Christian =?iso-8859-1?Q?K=F6nig?= Hi! > >>>>index dac78ad..b86f06a 100644 > >>>>--- a/drivers/gpu/drm/radeon/atombios_crtc.c > >>>>+++ b/drivers/gpu/drm/radeon/atombios_crtc.c > >>>>@@ -569,6 +569,8 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc, > >>>> radeon_crtc->pll_flags = 0; > >>>> > >>>> if (ASIC_IS_AVIVO(rdev)) { > >>>>+ radeon_crtc->pll_flags |= RADEON_PLL_PREFER_MINM_OVER_MAXP; > >>>>+ > >>>> if ((rdev->family = CHIP_RS600) || > >>>> (rdev->family = CHIP_RS690) || > >>>> (rdev->family = CHIP_RS740)) > >>>> > >>>Help.. maybe... it is tricky to tell. It definitely does _not_ fix the > >>>issue completely. > >>You could also try the old pll algorithm: > >I reverted the patch above, and switched to the old algorithm. > > > >The flicker is still there. (But maybe its less horrible, like with > >RADEON_PLL_PREFER_MINM_OVER_MAXP). > > The flickering would vanish completely if that's the reason for the issue > you are seeing. > Try setting ref_div_min and ref_div_max to 2 in > radeon_compute_pll_avivo(). Ok, I did this, but no luck, still flickers. But the flicker only happens when something changes on screen, like dragging a big window. Is that consistent with wrong PLL timings? diff --git a/config.32 b/config.32 index 00e5dd2..4734158 100644 --- a/config.32 +++ b/config.32 @@ -1090,7 +1090,7 @@ CONFIG_DEVTMPFS_MOUNT=y CONFIG_PREVENT_FIRMWARE_BUILD=y CONFIG_FW_LOADER=y CONFIG_FIRMWARE_IN_KERNEL=y -CONFIG_EXTRA_FIRMWARE="radeon/R700_rlc.bin" +CONFIG_EXTRA_FIRMWARE="radeon/R700_rlc.bin radeon/RV710_smc.bin radeon/RV710_uvd.bin" CONFIG_EXTRA_FIRMWARE_DIR="/lib/firmware" # CONFIG_FW_LOADER_USER_HELPER_FALLBACK is not set CONFIG_ALLOW_DEV_COREDUMP=y diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/radeon/atombios_crtc.c index dac78ad..dcc4f4d 100644 --- a/drivers/gpu/drm/radeon/atombios_crtc.c +++ b/drivers/gpu/drm/radeon/atombios_crtc.c @@ -569,6 +569,8 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc, radeon_crtc->pll_flags = 0; if (ASIC_IS_AVIVO(rdev)) { + //radeon_crtc->pll_flags |= RADEON_PLL_PREFER_MINM_OVER_MAXP; + if ((rdev->family = CHIP_RS600) || (rdev->family = CHIP_RS690) || (rdev->family = CHIP_RS740)) diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c index 6743174..bebaf4f 100644 --- a/drivers/gpu/drm/radeon/radeon_display.c +++ b/drivers/gpu/drm/radeon/radeon_display.c @@ -947,6 +947,7 @@ void radeon_compute_pll_avivo(struct radeon_pll *pll, fb_div_max = pll->max_feedback_div; if (pll->flags & RADEON_PLL_USE_FRAC_FB_DIV) { + printk("radeon: fractional divider\n"); fb_div_min *= 10; fb_div_max *= 10; } @@ -966,6 +967,9 @@ void radeon_compute_pll_avivo(struct radeon_pll *pll, else ref_div_max = pll->max_ref_div; + ref_div_min = 2; + ref_div_max = 2; + /* determine allowed post divider range */ if (pll->flags & RADEON_PLL_USE_POST_DIV) { post_div_min = pll->post_div; @@ -1020,6 +1024,8 @@ void radeon_compute_pll_avivo(struct radeon_pll *pll, diff = abs(target_clock - (pll->reference_freq * fb_div) / (ref_div * post_div)); + printk("post_div = %d, diff = %d\n", post_div, diff); + if (diff < diff_best || (diff = diff_best && !(pll->flags & RADEON_PLL_PREFER_MINM_OVER_MAXP))) { @@ -1028,6 +1034,7 @@ void radeon_compute_pll_avivo(struct radeon_pll *pll, } } post_div = post_div_best; + printk("Selected post_div = %d\n", post_div); /* get the feedback and reference divider for the optimal value */ avivo_get_fb_ref_div(nom, den, post_div, fb_div_max, ref_div_max, @@ -1062,7 +1069,7 @@ void radeon_compute_pll_avivo(struct radeon_pll *pll, *ref_div_p = ref_div; *post_div_p = post_div; - DRM_DEBUG_KMS("%d - %d, pll dividers - fb: %d.%d ref: %d, post %d\n", + printk("%d - %d, pll dividers - fb: %d.%d ref: %d, post %d\n", freq, *dot_clock_p * 10, *fb_div_p, *frac_fb_div_p, ref_div, post_div); } > But I'm not 100% convinced that this is actually a PLL problem, try to > compile the firmware it complains about into the kernel as well. Did that, too. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: Mobility Radeon HD 4530/4570/545v: flicker in 1920x1080 Date: Wed, 4 Nov 2015 23:10:00 +0100 Message-ID: <20151104221000.GA3608@amd> References: <20151031201344.GA30459@amd> <563522C5.1000206@amd.com> <20151031212259.GA6253@amd> <20151103220919.GA4824@amd> <20151103230329.GA4167@amd> <5639B580.1050409@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from atrey.karlin.mff.cuni.cz (atrey.karlin.mff.cuni.cz [195.113.26.193]) by gabe.freedesktop.org (Postfix) with ESMTP id A3FDE6E7B7 for ; Wed, 4 Nov 2015 14:10:04 -0800 (PST) Content-Disposition: inline In-Reply-To: <5639B580.1050409@vodafone.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: "linux-fbdev@vger.kernel.org" , kernel list , Maling list - DRI developers , "Deucher, Alexander" , Christian =?iso-8859-1?Q?K=F6nig?= List-Id: dri-devel@lists.freedesktop.org SGkhCgo+ID4+Pj5pbmRleCBkYWM3OGFkLi5iODZmMDZhIDEwMDY0NAo+ID4+Pj4tLS0gYS9kcml2 ZXJzL2dwdS9kcm0vcmFkZW9uL2F0b21iaW9zX2NydGMuYwo+ID4+Pj4rKysgYi9kcml2ZXJzL2dw dS9kcm0vcmFkZW9uL2F0b21iaW9zX2NydGMuYwo+ID4+Pj5AQCAtNTY5LDYgKzU2OSw4IEBAIHN0 YXRpYyB1MzIgYXRvbWJpb3NfYWRqdXN0X3BsbChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gPj4+ PiAgICAgICAgIHJhZGVvbl9jcnRjLT5wbGxfZmxhZ3MgPSAwOwo+ID4+Pj4KPiA+Pj4+ICAgICAg ICAgaWYgKEFTSUNfSVNfQVZJVk8ocmRldikpIHsKPiA+Pj4+KyAgICAgICAgICAgICAgIHJhZGVv bl9jcnRjLT5wbGxfZmxhZ3MgfD0gUkFERU9OX1BMTF9QUkVGRVJfTUlOTV9PVkVSX01BWFA7Cj4g Pj4+PisKPiA+Pj4+ICAgICAgICAgICAgICAgICBpZiAoKHJkZXYtPmZhbWlseSA9PSBDSElQX1JT NjAwKSB8fAo+ID4+Pj4gICAgICAgICAgICAgICAgICAgICAocmRldi0+ZmFtaWx5ID09IENISVBf UlM2OTApIHx8Cj4gPj4+PiAgICAgICAgICAgICAgICAgICAgIChyZGV2LT5mYW1pbHkgPT0gQ0hJ UF9SUzc0MCkpCj4gPj4+Pgo+ID4+PkhlbHAuLiBtYXliZS4uLiBpdCBpcyB0cmlja3kgdG8gdGVs bC4gSXQgZGVmaW5pdGVseSBkb2VzIF9ub3RfIGZpeCB0aGUKPiA+Pj5pc3N1ZSBjb21wbGV0ZWx5 Lgo+ID4+WW91IGNvdWxkIGFsc28gdHJ5IHRoZSBvbGQgcGxsIGFsZ29yaXRobToKPiA+SSByZXZl cnRlZCB0aGUgcGF0Y2ggYWJvdmUsIGFuZCBzd2l0Y2hlZCB0byB0aGUgb2xkIGFsZ29yaXRobS4K PiA+Cj4gPlRoZSBmbGlja2VyIGlzIHN0aWxsIHRoZXJlLiAoQnV0IG1heWJlIGl0cyBsZXNzIGhv cnJpYmxlLCBsaWtlIHdpdGgKPiA+UkFERU9OX1BMTF9QUkVGRVJfTUlOTV9PVkVSX01BWFApLgo+ IAo+IFRoZSBmbGlja2VyaW5nIHdvdWxkIHZhbmlzaCBjb21wbGV0ZWx5IGlmIHRoYXQncyB0aGUg cmVhc29uIGZvciB0aGUgaXNzdWUKPiB5b3UgYXJlIHNlZWluZy4KCj4gVHJ5IHNldHRpbmcgcmVm X2Rpdl9taW4gYW5kIHJlZl9kaXZfbWF4IHRvIDIgaW4KPiAgcmFkZW9uX2NvbXB1dGVfcGxsX2F2 aXZvKCkuCgpPaywgSSBkaWQgdGhpcywgYnV0IG5vIGx1Y2ssIHN0aWxsIGZsaWNrZXJzLiBCdXQg dGhlIGZsaWNrZXIgb25seQpoYXBwZW5zIHdoZW4gc29tZXRoaW5nIGNoYW5nZXMgb24gc2NyZWVu LCBsaWtlIGRyYWdnaW5nIGEgYmlnCndpbmRvdy4gSXMgdGhhdCBjb25zaXN0ZW50IHdpdGggd3Jv bmcgUExMIHRpbWluZ3M/CgpkaWZmIC0tZ2l0IGEvY29uZmlnLjMyIGIvY29uZmlnLjMyCmluZGV4 IDAwZTVkZDIuLjQ3MzQxNTggMTAwNjQ0Ci0tLSBhL2NvbmZpZy4zMgorKysgYi9jb25maWcuMzIK QEAgLTEwOTAsNyArMTA5MCw3IEBAIENPTkZJR19ERVZUTVBGU19NT1VOVD15CiBDT05GSUdfUFJF VkVOVF9GSVJNV0FSRV9CVUlMRD15CiBDT05GSUdfRldfTE9BREVSPXkKIENPTkZJR19GSVJNV0FS RV9JTl9LRVJORUw9eQotQ09ORklHX0VYVFJBX0ZJUk1XQVJFPSJyYWRlb24vUjcwMF9ybGMuYmlu IgorQ09ORklHX0VYVFJBX0ZJUk1XQVJFPSJyYWRlb24vUjcwMF9ybGMuYmluIHJhZGVvbi9SVjcx MF9zbWMuYmluIHJhZGVvbi9SVjcxMF91dmQuYmluIgogQ09ORklHX0VYVFJBX0ZJUk1XQVJFX0RJ Uj0iL2xpYi9maXJtd2FyZSIKICMgQ09ORklHX0ZXX0xPQURFUl9VU0VSX0hFTFBFUl9GQUxMQkFD SyBpcyBub3Qgc2V0CiBDT05GSUdfQUxMT1dfREVWX0NPUkVEVU1QPXkKZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9yYWRlb24vYXRvbWJpb3NfY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJtL3Jh ZGVvbi9hdG9tYmlvc19jcnRjLmMKaW5kZXggZGFjNzhhZC4uZGNjNGY0ZCAxMDA2NDQKLS0tIGEv ZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9hdG9tYmlvc19jcnRjLmMKKysrIGIvZHJpdmVycy9ncHUv ZHJtL3JhZGVvbi9hdG9tYmlvc19jcnRjLmMKQEAgLTU2OSw2ICs1NjksOCBAQCBzdGF0aWMgdTMy IGF0b21iaW9zX2FkanVzdF9wbGwoc3RydWN0IGRybV9jcnRjICpjcnRjLAogCXJhZGVvbl9jcnRj LT5wbGxfZmxhZ3MgPSAwOwogCiAJaWYgKEFTSUNfSVNfQVZJVk8ocmRldikpIHsKKwkJLy9yYWRl b25fY3J0Yy0+cGxsX2ZsYWdzIHw9IFJBREVPTl9QTExfUFJFRkVSX01JTk1fT1ZFUl9NQVhQOwor CiAJCWlmICgocmRldi0+ZmFtaWx5ID09IENISVBfUlM2MDApIHx8CiAJCSAgICAocmRldi0+ZmFt aWx5ID09IENISVBfUlM2OTApIHx8CiAJCSAgICAocmRldi0+ZmFtaWx5ID09IENISVBfUlM3NDAp KQpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fZGlzcGxheS5jIGIv ZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fZGlzcGxheS5jCmluZGV4IDY3NDMxNzQuLmJl YmFmNGYgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2Rpc3BsYXku YworKysgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9kaXNwbGF5LmMKQEAgLTk0Nyw2 ICs5NDcsNyBAQCB2b2lkIHJhZGVvbl9jb21wdXRlX3BsbF9hdml2byhzdHJ1Y3QgcmFkZW9uX3Bs bCAqcGxsLAogCWZiX2Rpdl9tYXggPSBwbGwtPm1heF9mZWVkYmFja19kaXY7CiAKIAlpZiAocGxs LT5mbGFncyAmIFJBREVPTl9QTExfVVNFX0ZSQUNfRkJfRElWKSB7CisJCXByaW50aygicmFkZW9u OiBmcmFjdGlvbmFsIGRpdmlkZXJcbiIpOwogCQlmYl9kaXZfbWluICo9IDEwOwogCQlmYl9kaXZf bWF4ICo9IDEwOwogCX0KQEAgLTk2Niw2ICs5NjcsOSBAQCB2b2lkIHJhZGVvbl9jb21wdXRlX3Bs bF9hdml2byhzdHJ1Y3QgcmFkZW9uX3BsbCAqcGxsLAogCWVsc2UKIAkJcmVmX2Rpdl9tYXggPSBw bGwtPm1heF9yZWZfZGl2OwogCisJcmVmX2Rpdl9taW4gPSAyOworCXJlZl9kaXZfbWF4ID0gMjsK KwogCS8qIGRldGVybWluZSBhbGxvd2VkIHBvc3QgZGl2aWRlciByYW5nZSAqLwogCWlmIChwbGwt PmZsYWdzICYgUkFERU9OX1BMTF9VU0VfUE9TVF9ESVYpIHsKIAkJcG9zdF9kaXZfbWluID0gcGxs LT5wb3N0X2RpdjsKQEAgLTEwMjAsNiArMTAyNCw4IEBAIHZvaWQgcmFkZW9uX2NvbXB1dGVfcGxs X2F2aXZvKHN0cnVjdCByYWRlb25fcGxsICpwbGwsCiAJCWRpZmYgPSBhYnModGFyZ2V0X2Nsb2Nr IC0gKHBsbC0+cmVmZXJlbmNlX2ZyZXEgKiBmYl9kaXYpIC8KIAkJCShyZWZfZGl2ICogcG9zdF9k aXYpKTsKIAorCQlwcmludGsoInBvc3RfZGl2ID0gJWQsIGRpZmYgPSAlZFxuIiwgcG9zdF9kaXYs IGRpZmYpOworCiAJCWlmIChkaWZmIDwgZGlmZl9iZXN0IHx8IChkaWZmID09IGRpZmZfYmVzdCAm JgogCQkgICAgIShwbGwtPmZsYWdzICYgUkFERU9OX1BMTF9QUkVGRVJfTUlOTV9PVkVSX01BWFAp KSkgewogCkBAIC0xMDI4LDYgKzEwMzQsNyBAQCB2b2lkIHJhZGVvbl9jb21wdXRlX3BsbF9hdml2 byhzdHJ1Y3QgcmFkZW9uX3BsbCAqcGxsLAogCQl9CiAJfQogCXBvc3RfZGl2ID0gcG9zdF9kaXZf YmVzdDsKKwlwcmludGsoIlNlbGVjdGVkIHBvc3RfZGl2ID0gJWRcbiIsIHBvc3RfZGl2KTsKIAog CS8qIGdldCB0aGUgZmVlZGJhY2sgYW5kIHJlZmVyZW5jZSBkaXZpZGVyIGZvciB0aGUgb3B0aW1h bCB2YWx1ZSAqLwogCWF2aXZvX2dldF9mYl9yZWZfZGl2KG5vbSwgZGVuLCBwb3N0X2RpdiwgZmJf ZGl2X21heCwgcmVmX2Rpdl9tYXgsCkBAIC0xMDYyLDcgKzEwNjksNyBAQCB2b2lkIHJhZGVvbl9j b21wdXRlX3BsbF9hdml2byhzdHJ1Y3QgcmFkZW9uX3BsbCAqcGxsLAogCSpyZWZfZGl2X3AgPSBy ZWZfZGl2OwogCSpwb3N0X2Rpdl9wID0gcG9zdF9kaXY7CiAKLQlEUk1fREVCVUdfS01TKCIlZCAt ICVkLCBwbGwgZGl2aWRlcnMgLSBmYjogJWQuJWQgcmVmOiAlZCwgcG9zdCAlZFxuIiwKKwlwcmlu dGsoIiVkIC0gJWQsIHBsbCBkaXZpZGVycyAtIGZiOiAlZC4lZCByZWY6ICVkLCBwb3N0ICVkXG4i LAogCQkgICAgICBmcmVxLCAqZG90X2Nsb2NrX3AgKiAxMCwgKmZiX2Rpdl9wLCAqZnJhY19mYl9k aXZfcCwKIAkJICAgICAgcmVmX2RpdiwgcG9zdF9kaXYpOwogfQoKCj4gQnV0IEknbSBub3QgMTAw JSBjb252aW5jZWQgdGhhdCB0aGlzIGlzIGFjdHVhbGx5IGEgUExMIHByb2JsZW0sIHRyeSB0bwo+ IGNvbXBpbGUgdGhlIGZpcm13YXJlIGl0IGNvbXBsYWlucyBhYm91dCBpbnRvIHRoZSBrZXJuZWwg YXMgd2VsbC4KCkRpZCB0aGF0LCB0b28uCgpCZXN0IHJlZ2FyZHMsCgkJCQkJCQkJCVBhdmVsCi0t IAooZW5nbGlzaCkgaHR0cDovL3d3dy5saXZlam91cm5hbC5jb20vfnBhdmVsbWFjaGVrCihjZXNr eSwgcGljdHVyZXMpIGh0dHA6Ly9hdHJleS5rYXJsaW4ubWZmLmN1bmkuY3ovfnBhdmVsL3BpY3R1 cmUvaG9yc2VzL2Jsb2cuaHRtbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031287AbbKDWKI (ORCPT ); Wed, 4 Nov 2015 17:10:08 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:34079 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031261AbbKDWKE (ORCPT ); Wed, 4 Nov 2015 17:10:04 -0500 Date: Wed, 4 Nov 2015 23:10:00 +0100 From: Pavel Machek To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: Alex Deucher , "Deucher, Alexander" , "linux-fbdev@vger.kernel.org" , Christian =?iso-8859-1?Q?K=F6nig?= , Maling list - DRI developers , kernel list Subject: Re: Mobility Radeon HD 4530/4570/545v: flicker in 1920x1080 Message-ID: <20151104221000.GA3608@amd> References: <20151031201344.GA30459@amd> <563522C5.1000206@amd.com> <20151031212259.GA6253@amd> <20151103220919.GA4824@amd> <20151103230329.GA4167@amd> <5639B580.1050409@vodafone.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5639B580.1050409@vodafone.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > >>>>index dac78ad..b86f06a 100644 > >>>>--- a/drivers/gpu/drm/radeon/atombios_crtc.c > >>>>+++ b/drivers/gpu/drm/radeon/atombios_crtc.c > >>>>@@ -569,6 +569,8 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc, > >>>> radeon_crtc->pll_flags = 0; > >>>> > >>>> if (ASIC_IS_AVIVO(rdev)) { > >>>>+ radeon_crtc->pll_flags |= RADEON_PLL_PREFER_MINM_OVER_MAXP; > >>>>+ > >>>> if ((rdev->family == CHIP_RS600) || > >>>> (rdev->family == CHIP_RS690) || > >>>> (rdev->family == CHIP_RS740)) > >>>> > >>>Help.. maybe... it is tricky to tell. It definitely does _not_ fix the > >>>issue completely. > >>You could also try the old pll algorithm: > >I reverted the patch above, and switched to the old algorithm. > > > >The flicker is still there. (But maybe its less horrible, like with > >RADEON_PLL_PREFER_MINM_OVER_MAXP). > > The flickering would vanish completely if that's the reason for the issue > you are seeing. > Try setting ref_div_min and ref_div_max to 2 in > radeon_compute_pll_avivo(). Ok, I did this, but no luck, still flickers. But the flicker only happens when something changes on screen, like dragging a big window. Is that consistent with wrong PLL timings? diff --git a/config.32 b/config.32 index 00e5dd2..4734158 100644 --- a/config.32 +++ b/config.32 @@ -1090,7 +1090,7 @@ CONFIG_DEVTMPFS_MOUNT=y CONFIG_PREVENT_FIRMWARE_BUILD=y CONFIG_FW_LOADER=y CONFIG_FIRMWARE_IN_KERNEL=y -CONFIG_EXTRA_FIRMWARE="radeon/R700_rlc.bin" +CONFIG_EXTRA_FIRMWARE="radeon/R700_rlc.bin radeon/RV710_smc.bin radeon/RV710_uvd.bin" CONFIG_EXTRA_FIRMWARE_DIR="/lib/firmware" # CONFIG_FW_LOADER_USER_HELPER_FALLBACK is not set CONFIG_ALLOW_DEV_COREDUMP=y diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/radeon/atombios_crtc.c index dac78ad..dcc4f4d 100644 --- a/drivers/gpu/drm/radeon/atombios_crtc.c +++ b/drivers/gpu/drm/radeon/atombios_crtc.c @@ -569,6 +569,8 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc, radeon_crtc->pll_flags = 0; if (ASIC_IS_AVIVO(rdev)) { + //radeon_crtc->pll_flags |= RADEON_PLL_PREFER_MINM_OVER_MAXP; + if ((rdev->family == CHIP_RS600) || (rdev->family == CHIP_RS690) || (rdev->family == CHIP_RS740)) diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c index 6743174..bebaf4f 100644 --- a/drivers/gpu/drm/radeon/radeon_display.c +++ b/drivers/gpu/drm/radeon/radeon_display.c @@ -947,6 +947,7 @@ void radeon_compute_pll_avivo(struct radeon_pll *pll, fb_div_max = pll->max_feedback_div; if (pll->flags & RADEON_PLL_USE_FRAC_FB_DIV) { + printk("radeon: fractional divider\n"); fb_div_min *= 10; fb_div_max *= 10; } @@ -966,6 +967,9 @@ void radeon_compute_pll_avivo(struct radeon_pll *pll, else ref_div_max = pll->max_ref_div; + ref_div_min = 2; + ref_div_max = 2; + /* determine allowed post divider range */ if (pll->flags & RADEON_PLL_USE_POST_DIV) { post_div_min = pll->post_div; @@ -1020,6 +1024,8 @@ void radeon_compute_pll_avivo(struct radeon_pll *pll, diff = abs(target_clock - (pll->reference_freq * fb_div) / (ref_div * post_div)); + printk("post_div = %d, diff = %d\n", post_div, diff); + if (diff < diff_best || (diff == diff_best && !(pll->flags & RADEON_PLL_PREFER_MINM_OVER_MAXP))) { @@ -1028,6 +1034,7 @@ void radeon_compute_pll_avivo(struct radeon_pll *pll, } } post_div = post_div_best; + printk("Selected post_div = %d\n", post_div); /* get the feedback and reference divider for the optimal value */ avivo_get_fb_ref_div(nom, den, post_div, fb_div_max, ref_div_max, @@ -1062,7 +1069,7 @@ void radeon_compute_pll_avivo(struct radeon_pll *pll, *ref_div_p = ref_div; *post_div_p = post_div; - DRM_DEBUG_KMS("%d - %d, pll dividers - fb: %d.%d ref: %d, post %d\n", + printk("%d - %d, pll dividers - fb: %d.%d ref: %d, post %d\n", freq, *dot_clock_p * 10, *fb_div_p, *frac_fb_div_p, ref_div, post_div); } > But I'm not 100% convinced that this is actually a PLL problem, try to > compile the firmware it complains about into the kernel as well. Did that, too. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html